Skip to content

CI for Node#2

Open
ghost wants to merge 5 commits into
masterfrom
varun7447-patch-2
Open

CI for Node#2
ghost wants to merge 5 commits into
masterfrom
varun7447-patch-2

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 12, 2019

No description provided.

@github-learning-lab
Copy link
Copy Markdown

Templated workflow success!

Great job adding the templated workflow. Adding that file to this branch is enough for GitHub Actions to begin running CI on your repository. This takes a couple of minutes, so let's take this opportunity to learn about some of the components of the workflow file you just added. We'll dive deeper into some of the key elements of this file in future steps of the course.

Step 2: Run a templated workflow

I'll respond when GitHub Actions finishes running the workflow. You can follow along in the Actions tab, or by clicking Details on the pending status below.


Actions workflow not running? Click here

When a GitHub Actions workflow is running, you should see some checks in progress, like the screenshot below.

checks in progress in a merge box

If the checks don't appear or if the checks are stuck in progress, there's a few things you can do to try and trigger them:

  • Refresh the page, it's possible the workflow ran and the page just hasn't been updated with that change
  • Try making a commit on this branch. Our workflow is triggered with a push event, and committing to this branch will result in a new push
  • Edit the workflow file on GitHub and ensure there are no red lines indicating a syntax problem

Comment thread .github/workflows/nodejs.yml
Comment thread .github/workflows/nodejs.yml
Comment thread .github/workflows/nodejs.yml
Comment thread .github/workflows/nodejs.yml
@github-learning-lab
Copy link
Copy Markdown

Running - and failing - workflow

The workflow ran! But it failed 😭. But, that's OK. Every time CI fails, it's an opportunity to learn from what's causing it. By running CI with GitHub Actions, we have access to the logs for the attempted build. These are found:

  • In the Actions tab
  • In the merge box for this pull request, by clicking on "Details".

If you navigate over to the build logs, you may notice that the error is "No tests found".

screenshot of build log showing a missing __test__ directory

Learning how to read build logs and isolate the cause of the problem is an art on its own. We'll try and cover some of the basics here. In our case, the source of the error is the npm test command. The npm test command looks for a testing framework. We want to use Jest, as we mentioned earlier. Jest requires unit tests in a directory named __test__. A __test__ directory doesn't exist on this branch.

Step 3: Add your first test

Not to worry, I've got you covered! Navigate to the open pull request titled Add Jest tests and merge it into this branch. That'll get us the test files we need. I'll respond when you merge the Add Jest tests pull request into this branch.

⌨️ Activity: Add your first test script for CI to pick up

  1. Navigate to the open pull request titled Add Jest tests
  2. Merge the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants