Skip to content

feature: use avaliable space if first sub is too large #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
birdspider wants to merge 1 commit into
base: 2.0.0-dev
Choose a base branch
from
Open

feature: use avaliable space if first sub is too large #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions packages/smartmenus-configurator/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,56 @@ const navbarContentHTML = computed(() => {
<li class="sm-sub-item"><a class="sm-sub-link sm-disabled" href="#">Disabled</a></li>
</ul>
</li>
<li class="sm-nav-item"><a class="sm-nav-link sm-sub-toggler" href="#">Long-Sub</a>
<ul class="sm-sub">
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link sm-sub-toggler" href="#">Sub</a>
<ul class="sm-sub">
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link sm-sub-toggler" href="#">Sub</a>
<ul class="sm-sub">
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
</ul>
</li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
</ul>
</li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link sm-sub-toggler" href="#">Long-Sub</a>
<ul class="sm-sub">
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
</ul>
</li>
<li class="sm-sub-item"><a class="sm-sub-link" href="#">Link</a></li>
<li class="sm-sub-item-separator"></li>
<li class="sm-sub-item"><a class="sm-sub-link sm-disabled" href="#">Disabled</a></li>
</ul>
</li>
<li class="sm-nav-item"><a class="sm-nav-link" href="#">Link</a></li>
<li class="sm-nav-item"><a class="sm-nav-link" href="#">Link</a></li>
<li class="sm-nav-item"><a class="sm-nav-link sm-nav-link--split" href="#">Link</a><button class="sm-nav-link sm-nav-link--split sm-sub-toggler" aria-label="Toggle sub menu"></button>
Expand Down
29 changes: 17 additions & 12 deletions packages/smartmenus/src/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,19 +980,24 @@ class SmartMenus {
x = -parentItemX
}

if (!horizontalParent) {
if (subHeight < viewportHeight) {
if (parentItemY + y + subHeight > viewportHeight) {
// Align against the opposite edge of the viewport
y = viewportHeight - subHeight - parentItemY
} else if (parentItemY + y < 0) {
// Align against the same edge of the viewport
y = -parentItemY
}
} else {
// If the sub cannot fit inside the viewport, align it against the top edge of the viewport
y = downToUp ? viewportHeight - subHeight - parentItemY : -parentItemY
if (horizontalParent) {
const overHang = subHeight - (viewportHeight - (parentItemY + y))
if (overHang > 0) {
const liftBy = Math.max(y - overHang, -parentItemY) // at most lift to edge
x = parentItemWidth // align sub to the side
y = liftBy // lift sub
}
} else if (subHeight < viewportHeight) {
if (parentItemY + y + subHeight > viewportHeight) {
// Align against the opposite edge of the viewport
y = viewportHeight - subHeight - parentItemY
} else if (parentItemY + y < 0) {
// Align against the same edge of the viewport
y = -parentItemY
}
} else {
// If the sub cannot fit inside the viewport, align it against the top edge of the viewport
y = downToUp ? viewportHeight - subHeight - parentItemY : -parentItemY
}
}

Expand Down