Skip to content

feature: use avaliable space if first sub is too large#248

Open
birdspider wants to merge 1 commit into
vadikom:2.0.0-devfrom
birdspider:feature/make-first-sub-use-avaliable-space
Open

feature: use avaliable space if first sub is too large#248
birdspider wants to merge 1 commit into
vadikom:2.0.0-devfrom
birdspider:feature/make-first-sub-use-avaliable-space

Conversation

@birdspider
Copy link
Copy Markdown

@birdspider birdspider commented Apr 19, 2024

hi,

I would need something like this, do you want it upstreamed or should I maintain this separately ?

Feedback is also welcome.

Regards

--

this shifts long subs sideways and up/down into available space (is easily visible in the configurator by using a small vh and opening "Long-Sub")

EDIT: I should add, this is in response to scroll not being implemented (yet?) in sm2.0 (in sm1.0 there was an up/down icon which shifted the items), if scroll gets implemented (I could help a bit) - this PR may be unnecessary

by shifting sideways and lifting/lowering
@vadikom
Copy link
Copy Markdown
Owner

vadikom commented Apr 23, 2024

Yep, indeed, my idea was to implement some kind of scroll later (most probably as an addon/extension since I realized this is quite a bit of code most users won't need).

The problem with a generic solution like yours is that when auto-lifted up the sub usually covers some of the sibling main menu items right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants