Framework: Remove GTest package #14719
Conversation
No need to provide GTest as a package for downstream customers. This was a legacy concept that was still available for backwards-compatibility. Discussed at-length in trilinos#8001 Signed-off-by: Samuel E. Browne <[email protected]>
As opposed to a Trilinos package. I don't know that this was strictly necessary with modern TriBITS, but still seemed to be more indicative of what the intent is. Signed-off-by: Samuel E. Browne <[email protected]>
Will need to put this in the container image long-term, but for now this is fine as a temporary solution. Signed-off-by: Samuel E. Browne <[email protected]>
sebrowne
added
AT2-SpecialApprove
|
CDash for AT1 results [Only accessible from Sandia networks] |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Using Repos:
Pull Request Author: sebrowne |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand) |
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
2 similar comments
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
2 participants
@trilinos/framework
Motivation
Using GTest for unit tests inside of Trilinos is perfectly acceptable. Requiring developers/users who wish to use Googletest for testing to have it already installed if those packages require it as a TPL. Alternatively, it can be "snapshotted" into a specific package (e.g. what Sacado does which is also shared with ShyLU).
Also requires adding Googletest to the environment, which I added via a small action. Long term approach will be to add this to all of the container images.
Related Issues
Closes #8001
Testing
Tested with GCC + OpenMPI (including local add of Googletest install), letting CI test the rest.