Framework: Upgrade GCC #14709

sebrowne · 2025-11-18T18:28:17Z

@trilinos/framework

Motivation

As mentioned in #14666, the new Kokkos + Trilinos exhibits errors with Intrepid2. Bump the main GCC image to GCC12 to avoid these issues.

Related Issues

https://sems-atlassian-son.sandia.gov/jira/browse/TRILFRAME-739

Testing

Letting the CI test this.

github-actions · 2025-11-18T18:28:27Z

CDash for AT1 results [Only accessible from Sandia networks]
CDash for AT2 results [Currently only accessible from Sandia networks]

trilinos-autotester · 2025-11-18T18:32:41Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

trilinos-autotester · 2025-11-18T18:33:42Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 2716
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE;PA: Framework;AT2-SpecialApprove;16.2 release note
PULLREQUESTNUM	14709
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/sebrowne/Trilinos
TRILINOS_SOURCE_SHA	`e029b58`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`8231243`

Using Repos:

Repo: TRILINOS (sebrowne/Trilinos)

Pull Request Author: sebrowne

trilinos-autotester · 2025-11-18T18:51:06Z

Status Flag 'Pull Request AutoTester' - Error: Jenkins Jobs - A user has pushed a change to the PR before testing completed. NEW EVENT 'committed', ID C_kwDOAsJyMdoAKGMxMDk4NGI2MGIxZDE0ZDM2YjJhMmExMjRhYTViZGIyNTA1NjU3MTU... The Jenkins Jobs will be shutdown; Testing of this PR must occur again.

trilinos-autotester · 2025-11-18T18:51:16Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 2716
Status: ERROR

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE;PA: Framework;AT2-SpecialApprove;16.2 release note
PULLREQUESTNUM	14709
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/sebrowne/Trilinos
TRILINOS_SOURCE_SHA	`e029b58`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`8231243`

CDash Test Results for PR# 14709.

Wiki: How to Reproduce PR Testing Builds and Errors.

trilinos-autotester · 2025-11-18T20:16:01Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

trilinos-autotester · 2025-11-18T20:16:46Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 2719
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE;PA: Framework;AT2-SpecialApprove;16.2 release note
PULLREQUESTNUM	14709
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/sebrowne/Trilinos
TRILINOS_SOURCE_SHA	`c10984b`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`8231243`

Using Repos:

Repo: TRILINOS (sebrowne/Trilinos)

Pull Request Author: sebrowne

trilinos-autotester · 2025-11-18T21:01:59Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 2719
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE;PA: Framework;AT2-SpecialApprove;16.2 release note
PULLREQUESTNUM	14709
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/sebrowne/Trilinos
TRILINOS_SOURCE_SHA	`c10984b`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`8231243`

CDash Test Results for PR# 14709.

trilinos-autotester · 2025-11-18T21:02:16Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

trilinos-autotester · 2025-11-18T21:02:23Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

achauphan · 2025-11-18T21:45:19Z

It seems like there are issues with git operations over http & ssh, hence why git clone is returning 500 for cuda-uvm.

https://www.githubstatus.com/

sebrowne · 2025-11-19T17:40:09Z

Hmmm looks like there are warning-as-error flags that were not valid for GCC10 but are valid for GCC12, leading to an increase in error output. I'm going to try disabling them one-by-one to get a summary of which ones are causing us trouble.

trilinos-autotester · 2025-11-19T18:11:12Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

trilinos-autotester · 2025-11-19T18:11:20Z

Status Flag 'Pull Request AutoTester' - GitHub reports Mergeable status = False

Also add a new GCC12 + OpenMPI4 build. Because we have it named including the compiler version and it's marked as required I can't just delete it, so add the new one. Reduce the specificity of the versioning to make this easier (e.g. per-major-version) in the future. Signed-off-by: Samuel E. Browne <[email protected]>

cgcgcg · 2025-11-19T18:48:58Z

@sebrowne There is a merge conflict. My PR for additional warnings-as-errors went in yesterday.

trilinos-autotester · 2025-11-19T18:51:10Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

trilinos-autotester · 2025-11-19T18:51:17Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Using Repos:

Repo: TRILINOS (sebrowne/Trilinos)

Pull Request Author: sebrowne

trilinos-autotester · 2025-11-19T18:51:43Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

CDash Test Results for PR# 14709.

trilinos-autotester · 2025-11-19T18:52:00Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

trilinos-autotester · 2025-11-19T18:52:07Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

trilinos-autotester · 2025-11-19T21:11:08Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

trilinos-autotester · 2025-11-19T21:11:16Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Using Repos:

Repo: TRILINOS (sebrowne/Trilinos)

Pull Request Author: sebrowne

trilinos-autotester · 2025-11-19T21:11:41Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

CDash Test Results for PR# 14709.

trilinos-autotester · 2025-11-19T21:11:59Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

trilinos-autotester · 2025-11-19T21:12:05Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

cgcgcg · 2025-11-20T00:35:32Z

@trilinos/framework That's fun: Looks like the Zoltan2 test is now also failing in this PR, but in the OpenMP test that this PR doesn't change.

I'm confused now:
This seems to suggest that the OpenMP build never passed this test?
https://sems-cdash-son.sandia.gov/cdash/queryTests.php?project=Trilinos&begin=2025-01-01&end=2025-11-20&filtercount=2&showfilters=1&filtercombine=and&field1=testname&compare1=61&value1=Zoltan2_TPLTraits_MPI_4&field2=buildname&compare2=63&value2=gcc-12.3.0-openmpi-4.1.6_release-debug_static_openmp

sebrowne · 2025-11-20T13:53:45Z

I'm confused now: This seems to suggest that the OpenMP build never passed this test?

Those first two "Not Runs" were because the build failed due to the flag issues, so the files didn't get built for the test.

This PR does change the OpenMP build to use the new toolchain. The title of that check isn't version-specific, so I changed it in-place. The "main" one is titled as gcc10, so we leave it and add a new one, switching over later.

Appears to be a GCC bug causing `restrict` warnings, and some `maybe-uninitialized` ones that are more senstive. Downgrade them to warnings since getting the compiler upgraded is time-sensitive. Same with `redundant-move` and `mismatched-new-delete`. Signed-off-by: Samuel E. Browne <[email protected]>

trilinos-autotester · 2025-11-20T14:05:14Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

trilinos-autotester · 2025-11-20T14:05:21Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Using Repos:

Repo: TRILINOS (sebrowne/Trilinos)

Pull Request Author: sebrowne

trilinos-autotester · 2025-11-20T14:05:48Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

CDash Test Results for PR# 14709.

trilinos-autotester · 2025-11-20T14:06:05Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

trilinos-autotester · 2025-11-20T14:06:12Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

trilinos-autotester · 2025-11-21T14:12:40Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

trilinos-autotester · 2025-11-22T14:29:44Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sebrowne added AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed PA: Framework Issues that fall under the Trilinos Framework Product Area AT2-SpecialApprove (Beta) Special approval label for AT2. 16.2 release note labels Nov 18, 2025

sebrowne changed the title ~~Framework: Upgrade gcc~~ Framework: Upgrade GCC Nov 18, 2025

sebrowne force-pushed the upgrade-gcc branch from e029b58 to c10984b Compare November 18, 2025 18:50

sebrowne added AT2-SpecialApprove (Beta) Special approval label for AT2. and removed AT2-SpecialApprove (Beta) Special approval label for AT2. labels Nov 18, 2025

cgcgcg mentioned this pull request Nov 19, 2025

Planning for releases 16.2 and 17.0 #14684

Open

sebrowne force-pushed the upgrade-gcc branch from 3eeb717 to 5b60f7a Compare November 19, 2025 18:49

sebrowne force-pushed the upgrade-gcc branch from 5b60f7a to 017551f Compare November 19, 2025 20:53

sebrowne force-pushed the upgrade-gcc branch from 017551f to 3b6511d Compare November 20, 2025 13:55

Framework: Upgrade GCC #14709

Are you sure you want to change the base?

Framework: Upgrade GCC #14709

Conversation

sebrowne commented Nov 18, 2025

Motivation

Related Issues

Testing

Uh oh!

github-actions bot commented Nov 18, 2025

Uh oh!

trilinos-autotester commented Nov 18, 2025

Uh oh!

trilinos-autotester commented Nov 18, 2025

Build Information

Test Name: PR_gcc-openmpi-openmp

Jenkins Parameters

Using Repos:

Uh oh!

trilinos-autotester commented Nov 18, 2025

Uh oh!

trilinos-autotester commented Nov 18, 2025

Build Information

Test Name: PR_gcc-openmpi-openmp

Jenkins Parameters

Uh oh!

trilinos-autotester commented Nov 18, 2025

Uh oh!

trilinos-autotester commented Nov 18, 2025

Build Information

Test Name: PR_gcc-openmpi-openmp

Jenkins Parameters

Using Repos:

Uh oh!

trilinos-autotester commented Nov 18, 2025

Build Information

Test Name: PR_gcc-openmpi-openmp

Jenkins Parameters

Uh oh!

trilinos-autotester commented Nov 18, 2025

Uh oh!

trilinos-autotester commented Nov 18, 2025

Uh oh!

achauphan commented Nov 18, 2025

Uh oh!

sebrowne commented Nov 19, 2025

Uh oh!

trilinos-autotester commented Nov 19, 2025

Uh oh!

trilinos-autotester commented Nov 19, 2025

Uh oh!

cgcgcg commented Nov 19, 2025

Uh oh!

trilinos-autotester commented Nov 19, 2025

Uh oh!

trilinos-autotester commented Nov 19, 2025

Using Repos:

Uh oh!

trilinos-autotester commented Nov 19, 2025

Uh oh!

trilinos-autotester commented Nov 19, 2025

Uh oh!

trilinos-autotester commented Nov 19, 2025

Uh oh!

trilinos-autotester commented Nov 19, 2025

Uh oh!

trilinos-autotester commented Nov 19, 2025

Using Repos:

Uh oh!

trilinos-autotester commented Nov 19, 2025

Uh oh!

trilinos-autotester commented Nov 19, 2025

Uh oh!

trilinos-autotester commented Nov 19, 2025

Uh oh!

cgcgcg commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sebrowne commented Nov 20, 2025

Uh oh!

cgcgcg commented Nov 20, 2025 •

edited

Loading