Skip to content

fix(ios): prevent crash when printing images without internet connection #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tr3v3r merged 3 commits into from
Jun 27, 2025
Merged

fix(ios): prevent crash when printing images without internet connection #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f43524
fix(ios): prevent crash when printing images without internet connection
tolypash Jun 26, 2025
b69844c
fix: review comments
tolypash Jun 27, 2025
cae6c33
fix: error code returned
tolypash Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion package/ios/ImageManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@ + (UIImage *)getImageFromDictionarySource:(NSDictionary *)imageObj
if([urlString hasPrefix: @"http"] || [urlString hasPrefix: @"https"]) {
NSURL *url = [NSURL URLWithString: urlString];
NSData *data = [NSData dataWithContentsOfURL:url];
imageData = [[UIImage alloc] initWithData:data];
if (data && data.length > 0) {
imageData = [[UIImage alloc] initWithData:data];
} else {
imageData = nil;
}
} else {
imageData = [RCTConvert UIImage:imageObj];
}
Expand Down
5 changes: 5 additions & 0 deletions package/ios/ThePrinter.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,11 @@ -(int) addImage: (NSDictionary *)source
return EPOS2_ERR_MEMORY;
}
UIImage *data = [ImageManager getImageFromDictionarySource:source];
// Check if image loading failed (e.g., due to network issues)
if (data == nil) {
return EPOS2_ERR_FAILURE;
}

CGSize size = [ImageManager getImageCGSize:data width:width];
UIImage *scaledImage = [ImageManager scaleImage:data size:size];

Expand Down
Loading