fix(ios): prevent crash when printing images without internet connection#229
Merged
Conversation
- Add validation checks in ImageManager.m to handle nil data and invalid image dimensions
- Add error handling in ThePrinter.m to return EPOS2_ERR_PARAM instead of crashing
- Prevent UIGraphicsBeginImageContext crash with invalid size parameters
- Fix division by zero in getImageCGSize when image width is 0
Fixes crash: UIGraphicsBeginImageContext() failed to allocate CGBitampContext: size={472, 0}
tr3v3r
reviewed
Jun 27, 2025
Owner
|
Hello @tolypash Thank you very much for the contribution! I've made a short review and added a couple of comments. Please check once you have time. |
Contributor
Author
|
Happy to contribute |
Owner
|
Just released a new version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix crash when printing images without internet connection on iOS.
Problem
The app crashes with
UIGraphicsBeginImageContext() failed to allocate CGBitampContext: size={472, 0}when trying to print images while offline. This happens because:nildataUIGraphicsBeginImageContextWithOptionscrashes when called with invalid dimensionsSolution
Added comprehensive validation in the iOS image processing pipeline:
EPOS2_ERR_PARAMinstead of crashingChanges
Testing
Breaking Changes
None. This is a bug fix that improves error handling.
Checklist