Skip to content

mkdir, touch: update Dutch translation #17189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dmmqz
Copy link
Member

@dmmqz dmmqz commented Jul 9, 2025

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the translation edit Changes to an existing translation page(s). label Jul 9, 2025
@dmmqz
Copy link
Member Author

dmmqz commented Jul 9, 2025

The page is up to date, I think the bot is giving the warning due to the extra curly braces in the new command.

@sebastiaanspeck
Copy link
Member

Yes, you are correct, it is the bot who is complaining, but for now, leave the placeholders untranslated:
english_commands_as_string='mkdir {{}} mkdir {{}} {{}} mkdir {{}} {{}} {{}} mkdir {{}} {{path/to/{a,b}/{x,y,z}/{h,i,j}}}'

This needs to be fixed somewhere else and I don't have the time for that ATM.

@sebastiaanspeck
Copy link
Member

I think if there was an extra space between the last three } it is fixed as well.

sed 's/{{[^}]*}}/{{}}/g' |

@dmmqz
Copy link
Member Author

dmmqz commented Jul 10, 2025

Using the command sed -E 's/\{\{([^}]|(\{[^}]*\}))*\}\}/{{}}/g' pages.nl/common/mkdir.md does find and replace all the placeholders with nested curly braces (for up to 1 depth). I'm not sure if this would mess other things up though.

@sebastiaanspeck
Copy link
Member

I think if there was an extra space between the last three } it is fixed as well.

sed 's/{{[^}]*}}/{{}}/g' |

You need to change the English page as well :D

@github-actions github-actions bot added the page edit Changes to an existing page(s). label Jul 10, 2025
@dmmqz
Copy link
Member Author

dmmqz commented Jul 10, 2025

Unless I did something wrong (again), this also didn't work. Would replacing the sed command you linked with the command I sent here work? Otherwise I can keep the placeholder untranslated.

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages.nl/common/mkdir.md is outdated, based on the command contents itself, compared to the English page.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@sebastiaanspeck
Copy link
Member

Unless I did something wrong (again), this also didn't work. Would replacing the sed command you linked with the command I sent here work? Otherwise I can keep the placeholder untranslated.

No problem for now IMO. I still need to test your sed command on the whole sourcebase if it doesn't introduce any new issues.

@sebastiaanspeck
Copy link
Member

Unless I did something wrong (again), this also didn't work. Would replacing the sed command you linked with the command I sent here work? Otherwise I can keep the placeholder untranslated.

You could open an issue in this repo or here to not lose focus.

@dmmqz
Copy link
Member Author

dmmqz commented Jul 10, 2025

I have created an issue in this repo (#17198). Feel free to change or add anything that's missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s). translation edit Changes to an existing translation page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants