Use nil for object pointers and HKSampleType for generic sample iteration#16
Merged
tetujin merged 2 commits intofeature/healthkit-added-duration-obtain-funcfrom Feb 9, 2026
Merged
Conversation
Co-authored-by: tetujin <1227623+tetujin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on HealthKit function for obtaining data
Use nil for object pointers and HKSampleType for generic sample iteration
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback on PR #15 regarding Objective-C pointer conventions and type safety in HealthKit data fetching.
Changes:
fetchEndDate = NULLtofetchEndDate = nilin initializationHKQuantityType *toHKSampleType *inreadDataWithDataTypes:Rationale:
nilis the standard for Objective-C object pointers vsNULLfor C pointersHKSampleType *correctly handles all HealthKit sample types (quantity, category, correlation, workout) returned bydataTypesToRead, not just quantities💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.