Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds APIs to the HealthKit plugin to fetch HealthKit data up to a fixed end date (bounded query window), and wires additional callbacks during HealthKit sample processing.
Changes:
- Add
readAllData,readDataWithDataTypes:, andsetEndFetchDate:toAWAREHealthKit. - Emit
SensorEventHandlercallbacks from HealthKit quantity/category plugins while processing samples. - Minor cleanup in the HealthKit example app and a change to device metadata insertion.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Example/AWARE-HealthKit/AppDelegate.swift | Removes an extra blank line in HealthKit example setup. |
| AWAREFramework/Classes/Sensors/Device/AWAREDevice.m | Modifies how label-related data is added to the device info payload. |
| AWAREFramework/Classes/Plugins/HealthKit/AWAREHealthKitQuantity.m | Adds per-sample sensor event handler invocation while buffering HealthKit quantity results. |
| AWAREFramework/Classes/Plugins/HealthKit/AWAREHealthKitCategory.m | Adds per-sample sensor event handler invocation while buffering HealthKit category results. |
| AWAREFramework/Classes/Plugins/HealthKit/AWAREHealthKit.m | Introduces end-date bounding (fetchEndDate) and refactors “read all” into reusable methods. |
| AWAREFramework/Classes/Plugins/HealthKit/AWAREHealthKit.h | Exposes the new HealthKit fetch APIs in the public header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: tetujin <1227623+tetujin@users.noreply.github.com>
Use nil for object pointers and HKSampleType for generic sample iteration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.