Skip to content

Remove deprecated call to flatDoc.normalize #7011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025
Merged

Remove deprecated call to flatDoc.normalize #7011

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba81284
remove deprecated calll to flatDoc.normalize
rileyajones Jul 8, 2025
84e7c12
attempt to add jsoup as a direct depedency
rileyajones Jul 8, 2025
2d3bae0
address comments
rileyajones Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tensorboard/java/org/tensorflow/tensorboard/vulcanize/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ java_binary(
"@com_google_protobuf//:protobuf_java",
"@io_bazel_rules_closure//java/io/bazel/rules/closure:webpath",
"@io_bazel_rules_closure//java/io/bazel/rules/closure/webfiles:build_info_java_proto",
"@org_jsoup",
"@org_jsoup_external",
],
)

Expand Down
3 changes: 0 additions & 3 deletions tensorboard/java/org/tensorflow/tensorboard/vulcanize/Vulcanize.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,9 +460,6 @@ private static Document getFlattenedHTML5Document(Document document) {
}
}

// Create `<html>`, `<head>` and `<body>`.
flatDoc.normalise();

document.traverse(new FlatDocumentCopier(flatDoc));

for (Element subdoc : flatDoc.getElementsByTag("#root")) {
Expand Down
9 changes: 9 additions & 0 deletions third_party/workspace.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,3 +138,12 @@ def tensorboard_workspace(name = ""):
],
licenses = ["notice"], # Apache 2.0
)

java_import_external(
name = "org_jsoup_external",
jar_sha256 = "436adf71fe9f326e04fe134cd2785b261f0f4b9b60876adda1de3b6919463394",
jar_urls = [
"https://jsoup.org/packages/jsoup-1.21.1.jar",
],
licenses = ["reciprocal"], # BSD 3-clause, ICU, MPL 1.1, libpng (BSD/MIT-like), Academic Free License v. 2.0, BSD 2-clause, MIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://jsoup.org/license says that it is distributed under the MIT license, and according to this documentation, MIT license should be marked as "notice".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I believe I've addressed this correctly

)