Remove deprecated call to flatDoc.normalize #7011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcra
requested changes
Jul 8, 2025
third_party/workspace.bzl
Outdated
| jar_urls = [ | ||
| "https://jsoup.org/packages/jsoup-1.21.1.jar", | ||
| ], | ||
| licenses = ["reciprocal"], # BSD 3-clause, ICU, MPL 1.1, libpng (BSD/MIT-like), Academic Free License v. 2.0, BSD 2-clause, MIT |
There was a problem hiding this comment.
https://jsoup.org/license says that it is distributed under the MIT license, and according to this documentation, MIT license should be marked as "notice".
There was a problem hiding this comment.
Good catch, I believe I've addressed this correctly
rileyajones
changed the title
arcra
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
This was a deprecated call to a no-op function. The function has now been removed in a newer version of the library. We need to support this newer library version to unblock an internal lsc Googlers see cl/771125806
I also needed to add a new source for the jsoup dependency. Previously this was being provided by the operating system (CI currently uses ubuntu 22.04 lts), but that version is now 3 years out of date.