Skip to content

cleanup: use {id} instead of {id: id} + minor typos #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KRISHNA-24BCS127 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cleanup: use {id} instead of {id: id} + minor typos #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/academicyears/academicyears.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ export class AcademicYearService {
async getAcademicYearById(id, response) {
const apiId = APIID.ACADEMICYEAR_GET;
try {
const academicYearResult = await this.academicYearRespository.findOne({ where: { id: id } });
const academicYearResult = await this.academicYearRespository.findOne({ where: { id } });
if (!academicYearResult) {
return APIResponse.error(
response,
Expand Down
2 changes: 1 addition & 1 deletion src/authRbac/authRbac.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class AuthRbacController {
@ApiHeader({
name: "tenantid",
required: true,
description: "Tenant Id",
description: "Tenant ID",
})
@ApiBasicAuth("access-token")
@UseGuards(JwtAuthGuard)
Expand Down
2 changes: 1 addition & 1 deletion src/cohort/cohort.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,7 +1049,7 @@ export class CohortService {
return APIResponse.error(
response,
apiId,
`Invalid Cohort Id format. It must be a valid UUID`,
`Invalid Cohort ID format. It must be a valid UUID`,
"Invalid cohortId",
HttpStatus.BAD_REQUEST
);
Expand Down
6 changes: 3 additions & 3 deletions src/location/location.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class LocationService {
const apiId = "api.find.location";
try {
const location = await this.locationRepository.find({
where: { id: id },
where: { id },
});
if (!location) {
return APIResponse.error(
Expand Down Expand Up @@ -82,7 +82,7 @@ export class LocationService {
const apiId = "api.update.location";
try {
const location = await this.locationRepository.find({
where: { id: id },
where: { id },
});
if (!location) {
return APIResponse.error(
Expand Down Expand Up @@ -117,7 +117,7 @@ export class LocationService {
const apiId = "api.delete.location";
try {
const location = await this.locationRepository.find({
where: { id: id },
where: { id },
});
if (!location) {
return APIResponse.error(
Expand Down