Skip to content

cleanup: use {id} instead of {id: id} + minor typos#694

Open
KRISHNA-24BCS127 wants to merge 1 commit intotekdi:mainfrom
KRISHNA-24BCS127:main
Open

cleanup: use {id} instead of {id: id} + minor typos#694
KRISHNA-24BCS127 wants to merge 1 commit intotekdi:mainfrom
KRISHNA-24BCS127:main

Conversation

@KRISHNA-24BCS127
Copy link
Copy Markdown

@KRISHNA-24BCS127 KRISHNA-24BCS127 commented Mar 17, 2026

clean up id syntax and fix ID typo

Summary by CodeRabbit

Release Notes

  • Style
    • Applied code formatting standardization and text capitalization improvements throughout the codebase for enhanced consistency.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ed49bf5d-4334-4082-a446-56291060a443

📥 Commits

Reviewing files that changed from the base of the PR and between d24e956 and 29af919.

📒 Files selected for processing (4)
  • src/academicyears/academicyears.service.ts
  • src/authRbac/authRbac.controller.ts
  • src/cohort/cohort.service.ts
  • src/location/location.service.ts

Walkthrough

This pull request applies consistent code cleanup patterns: converting object property shorthand syntax in repository queries and standardizing capitalization from "Id" to "ID" in API documentation and error messages across multiple service and controller files.

Changes

Cohort / File(s) Summary
Property Shorthand Refactoring
src/academicyears/academicyears.service.ts, src/location/location.service.ts
Converted object property from explicit { id: id } to ES6 shorthand { id } in database query where clauses (3 instances across both files).
Capitalization Fixes
src/authRbac/authRbac.controller.ts, src/cohort/cohort.service.ts
Standardized capitalization of "ID" in API header description and error message strings (changed from "Id" to "ID").

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: object shorthand syntax cleanup and minor typo fixes for 'ID' capitalization across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can customize the tone of the review comments and chat replies.

Configure the tone_instructions setting to customize the tone of the review comments and chat replies. For example, you can set the tone to Act like a strict teacher, Act like a pirate and more.

@sonarqubecloud
Copy link
Copy Markdown

@KRISHNA-24BCS127
Copy link
Copy Markdown
Author

@Sourav-Tekdi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant