Skip to content

ts_runtime: drop unregistered map request update log to debug - #373

Merged
dylan-tailscale merged 1 commit into
mainfrom
dylan/reg-log
Aug 14, 2026
Merged

ts_runtime: drop unregistered map request update log to debug#373
dylan-tailscale merged 1 commit into
mainfrom
dylan/reg-log

Conversation

@dylan-tailscale

Copy link
Copy Markdown
Collaborator

Drops a spurious log message to DEBUG-level; with the current architecture, this is expected to happen once on startup.

Signed-off-by: Dylan Bargatze <dylan@tailscale.com>

@nrc nrc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is still an error any time except the first, is it possible to log that error? Because otherwise it looks like it's just silently eaten. Don't worry if that is a pain though. In any case, I think a comment here (about when this is/isn't an error) would be useful

@npry npry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, how does this codepath even occur? oh, i see, it must be that it's getting new endpoints from netmon, which then triggers an attempt to tell control about them. @nrc yeah this could happen repeatedly, if we're not registered but keep getting updates from other actors that trigger an update request.

this indicates actually a more substantial bug, which i think we're only saved by from the fact that the derp latency measurement has to wait until the first netmap to see the derp map, and it succeeding necessarily triggers an update_map_request. if we didn't have that feedback path, the endpoints could go unobserved. i'll make a follow-up pr -- imo we shouldn't wait for it for 0.5.0 though, since it can't actually trigger

@dylan-tailscale
dylan-tailscale merged commit 741c70b into main Aug 14, 2026
23 checks passed
@dylan-tailscale
dylan-tailscale deleted the dylan/reg-log branch August 14, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants