runtime/control: populate initial maprequest - #374
Merged
Conversation
The initial maprequest wasn't populated with the info held by the control actor in a way consistent with future update_map_request calls. This didn't cause an issue because the derp latency map measurement always triggers an update_map_request (assuming it succeeds), but this was essentially a latent bug. Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: I83128caa6936b6f92abf301f0fe5acca6a6a6964
npry
force-pushed
the
npry/rt.ctrl.fix-init-mapreq
branch
from
August 14, 2026 17:19
2bd16df to
13576e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial maprequest wasn't populated with the info held by the control actor in a way consistent with future update_map_request calls. This didn't cause an issue because the derp latency map measurement always triggers an update_map_request (assuming it succeeds), but this was essentially a latent bug.
related to #373 (I'll rebase after it lands to include the log fix)