Skip to content

Handle spaces in SDK build paths #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Handle spaces in SDK build paths #219

wants to merge 1 commit into from
+3 −3

Conversation

euanh
Copy link
Contributor

@euanh euanh commented Jun 17, 2025 •
edited
Loading

Some Shell.run() calls do not quote paths, so paths which include spaces are not handled properly.

@euanh euanh changed the title tests: Include spaces in temporary build directory paths Handle spaces SDK build paths Jun 17, 2025
@euanh euanh changed the title Handle spaces SDK build paths Handle spaces in SDK build paths Jun 17, 2025
@euanh
Copy link
Contributor Author

euanh commented Jun 17, 2025

@swift-ci test

@euanh euanh force-pushed the deb-build-paths-with-spaces branch from 82d5f90 to 9e1afa2 Compare June 17, 2025 12:35
@euanh
Copy link
Contributor Author

euanh commented Jun 17, 2025

@swift-ci test

MaxDesiatov
MaxDesiatov approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@euanh @MaxDesiatov