generator: Quote paths when extracting Debian packages with Swift.run()

euanh · euanh · commit 9e1afa27ac10 · 2025-06-17T13:35:10.000+01:00
diff --git a/Sources/SwiftSDKGenerator/Generator/SwiftSDKGenerator.swift b/Sources/SwiftSDKGenerator/Generator/SwiftSDKGenerator.swift
@@ -163,12 +163,12 @@ public actor SwiftSDKGenerator {
 
   func rsync(from source: FilePath, to destination: FilePath) async throws {
     try self.createDirectoryIfNeeded(at: destination)
-    try await Shell.run("rsync -a \(source) \(destination)", shouldLogCommands: self.isVerbose)
+    try await Shell.run(#"rsync -a "\#(source)" "\#(destination)""#, shouldLogCommands: self.isVerbose)
   }
 
   func rsyncContents(from source: FilePath, to destination: FilePath) async throws {
     try self.createDirectoryIfNeeded(at: destination)
-    try await Shell.run("rsync -a \(source)/ \(destination)", shouldLogCommands: self.isVerbose)
+    try await Shell.run(#"rsync -a "\#(source)/" "\#(destination)""#, shouldLogCommands: self.isVerbose)
   }
 
   func createSymlink(at source: FilePath, pointingTo destination: FilePath) throws {
@@ -254,7 +254,7 @@ public actor SwiftSDKGenerator {
       stripComponentsOption = ""
     }
     try await Shell.run(
-      #"tar -C "\#(directoryPath)" \#(stripComponentsOption) -xf \#(file)"#,
+      #"tar -C "\#(directoryPath)" \#(stripComponentsOption) -xf "\#(file)""#,
       shouldLogCommands: self.isVerbose
     )
   }

Original file line number	Diff line number	Diff line change
`@@ -163,12 +163,12 @@ public actor SwiftSDKGenerator {`
`163`	`163`
`164`	`164`	`func rsync(from source: FilePath, to destination: FilePath) async throws {`
`165`	`165`	`try self.createDirectoryIfNeeded(at: destination)`
`166`		`- try await Shell.run("rsync -a \(source) \(destination)", shouldLogCommands: self.isVerbose)`
	`166`	`+ try await Shell.run(#"rsync -a "\#(source)" "\#(destination)""#, shouldLogCommands: self.isVerbose)`
`167`	`167`	`}`
`168`	`168`
`169`	`169`	`func rsyncContents(from source: FilePath, to destination: FilePath) async throws {`
`170`	`170`	`try self.createDirectoryIfNeeded(at: destination)`
`171`		`- try await Shell.run("rsync -a \(source)/ \(destination)", shouldLogCommands: self.isVerbose)`
	`171`	`+ try await Shell.run(#"rsync -a "\#(source)/" "\#(destination)""#, shouldLogCommands: self.isVerbose)`
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`func createSymlink(at source: FilePath, pointingTo destination: FilePath) throws {`
`@@ -254,7 +254,7 @@ public actor SwiftSDKGenerator {`
`254`	`254`	`stripComponentsOption = ""`
`255`	`255`	`}`
`256`	`256`	`try await Shell.run(`
`257`		`- #"tar -C "\#(directoryPath)" \#(stripComponentsOption) -xf \#(file)"#,`
	`257`	`+ #"tar -C "\#(directoryPath)" \#(stripComponentsOption) -xf "\#(file)""#,`
`258`	`258`	`shouldLogCommands: self.isVerbose`
`259`	`259`	`)`
`260`	`260`	`}`