Tests: Migrate PackageCommandTests to Swift Testing and Augment #9012

bkhouri · 2025-08-11T19:38:16Z

Migrate the PackageCommandTests to Swift Testing and augment the suite to run against the Native and SwiftBuild build system, in addition to the debug and release build configurations.

Depends on: #9020
Relates to: #8997
issue: rdar://157669245

bkhouri · 2025-08-11T21:39:11Z

@swift-ci test

Migrate the `BuildSystemDelegateTests` test to Swift Testing and augment the test to run against both the Native and SwiftBUild build system, in addition to the `debug`` and `release` build configuration. Depends on: swiftlang#9012 Relates to: swiftlang#8997 issue: rdar://157669245

cmcgee1024 · 2025-08-12T12:56:20Z

Tests/CommandsTests/PackageCommandTests.swift

+                }
+            }
+        } when: {
+            (ProcessInfo.hostOperatingSystem == .windows && data.buildSystem == .swiftbuild && !withPrettyPrinting)


suggestion (non-blocking): The known issue is with windows and the swiftbuild build system. I expect that the pretty printing doesn't impact this check at all, so I would remove the check whether pretty printing is not enabled.

This matches the XCTest version of the test.

Migrate a few suites to Swift Teting, namely, - SwiftSDKCommandTests - MultiRootSupportTests - SwiftCommandStateTests Depends on: swiftlang#9012 Relates to: swiftlang#8997 issue: rdar://157669245

bkhouri · 2025-08-13T04:28:33Z

@swift-ci test

bkhouri · 2025-08-13T18:44:34Z

@swift-ci test

bkhouri · 2025-08-13T20:05:18Z

@swift-ci test windows

bkhouri · 2025-08-14T16:05:59Z

@swift-ci test

bkhouri · 2025-08-14T16:09:43Z

@swift-ci test windows

bkhouri · 2025-08-14T19:20:08Z

@swift-ci test

bkhouri · 2025-08-14T20:06:18Z

@swift-ci test windows

bkhouri · 2025-08-17T01:31:33Z

@swift-ci test

bkhouri · 2025-08-18T14:10:14Z

@swift-ci test

bkhouri · 2025-08-18T14:13:33Z

@swift-ci test windows

Migrate the `BuildSystemDelegateTests` test to Swift Testing and augment the test to run against both the Native and SwiftBUild build system, in addition to the `debug`` and `release` build configuration. Depends on: swiftlang#9012 Relates to: swiftlang#8997 issue: rdar://157669245

bkhouri · 2025-08-18T19:41:19Z

@swift-ci test

bkhouri · 2025-08-18T19:52:56Z

@swift-ci test windows

Migrate the `BuildSystemDelegateTests` test to Swift Testing and augment the test to run against both the Native and SwiftBUild build system, in addition to the `debug`` and `release` build configuration. Depends on: swiftlang#9012 Relates to: swiftlang#8997 issue: rdar://157669245

Migrate the `PackageCommandTests` to Swift Testing and augment the suite to run against the Native and SwiftBuild build system, in addition to the `debug` and `release` build configurations. Relates to: swiftlang#8997 issue: rdar://157669245

bkhouri · 2025-08-19T13:30:58Z

@swift-ci test

bkhouri · 2025-08-19T14:13:50Z

@swift-ci test windows

bkhouri · 2025-08-19T17:10:03Z

@swift-ci test macOS

bkhouri · 2025-08-19T18:42:51Z

the macOS platform smoke test CI build failed unrelated to the change

14:18:26  + /usr/local/bin/sccache --stop-server
14:18:26  Stopping sccache server...
14:18:29  Cannot contact macos-node-i-054857cebc3a89e32: java.io.IOException: cannot find current thread
14:23:56  Cancelling nested steps due to timeout
14:23:56  Sending interrupt signal to process

Re-triggering the macOS pipelines

@swift-ci smoke test macOS platform

cachemeifyoucan · 2025-08-19T18:43:32Z

@swift-ci smoke test macOS platform

cachemeifyoucan · 2025-08-19T18:49:06Z

@swift-ci smoketest macOS platform

bkhouri · 2025-08-19T20:31:57Z

The macOS self hosted pipeline failed at the threadSafeBox test timed out. This is being addressed in #9045.
The macOS Platform test (smoke test) failed for an infrastructure issue, where sccache failed to stop

15:58:21  + /usr/local/bin/sccache --stop-server
15:58:21  Stopping sccache server...
15:58:24  Cannot contact macos-node-i-054857cebc3a89e32: java.io.IOException: cannot find current thread
16:03:51  Cancelling nested steps due to timeout
16:03:51  Sending interrupt signal to process
16:03:58  /Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test@tmp/durable-af179483/script.sh.copy: line 1: 59529 Terminated: 15          /usr/local/bin/sccache --stop-server

Re-triggering macOS builds

@swift-ci test macOS

bkhouri · 2025-08-20T14:35:23Z

@swift-ci test self hosted macos

bkhouri · 2025-08-20T14:35:38Z

@swift-ci test self hosted

bkhouri · 2025-08-20T17:39:08Z

The windows self hosted pipeline has been running for over 3 hours. Let's re-trigger the build

@swift-ci test self hosted windows

Migrate the `BuildSystemDelegateTests` test to Swift Testing and augment the test to run against both the Native and SwiftBUild build system, in addition to the `debug`` and `release` build configuration. Depends on: swiftlang#9012 Relates to: swiftlang#8997 issue: rdar://157669245

bkhouri · 2025-08-20T20:49:17Z

@swift-ci test self hosted windows

bkhouri · 2025-08-21T13:41:52Z

Windows self hosted failed due to a test failure

18:51:59  × Test completionToolListExecutables(data:) recorded an issue with 1 argument data → BuildData(buildSystem: SPMBuildCore.BuildSystemProvider.Kind.native, config: PackageModel.BuildConfiguration.release) at PackageCommandTests.swift:1171:17: Expectation failed: (result.stdout → "") == ("exec1\nexec2\n" → "exec1

18:51:59  exec2

18:51:59  ")

re-triggering to determine the occurrence

@swift-ci test self hosted windows

Migrate the `BuildSystemDelegateTests` test to Swift Testing and augment the test to run against both the Native and SwiftBUild build system, in addition to the `debug`` and `release` build configuration. Depends on: swiftlang#9012 Relates to: swiftlang#8997 issue: rdar://157669245

Migrate a few suites to Swift Teting, namely, - SwiftSDKCommandTests - MultiRootSupportTests Depends on: swiftlang#9012 Relates to: swiftlang#8997 issue: rdar://157669245

bkhouri mentioned this pull request Aug 11, 2025

Tests: Migrate BuildSystemDelegateTests to Swift Testing and augment #9013

Open

cmcgee1024 reviewed Aug 12, 2025

View reviewed changes

cmcgee1024 approved these changes Aug 12, 2025

View reviewed changes

bkhouri mentioned this pull request Aug 12, 2025

Tests: Migrate 2 suites to Swift Testing #9017

Open

bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST branch from 37217a5 to d505742 Compare August 12, 2025 17:50

bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST branch from d505742 to 0e692c0 Compare August 13, 2025 18:44

This was referenced Aug 13, 2025

Fix for .when(traits:) condition not working for multiple traits #9015

Merged

Fixup several warnings #9009

Merged

bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST branch from 0e692c0 to 5ce19cf Compare August 14, 2025 16:05

bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST branch from 5ce19cf to f2c5311 Compare August 14, 2025 19:19

bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST branch from f2c5311 to aace277 Compare August 18, 2025 14:10

bkhouri marked this pull request as ready for review August 18, 2025 14:10

bkhouri requested review from jakepetroules, dschaefer2, shawnhyam, bripeticca and plemarquand as code owners August 18, 2025 14:10

bkhouri requested a review from daveyc123 as a code owner August 18, 2025 14:10

jakepetroules approved these changes Aug 18, 2025

View reviewed changes

bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST branch from aace277 to 167d459 Compare August 18, 2025 19:41

bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST branch from 167d459 to 63a2165 Compare August 19, 2025 13:30

bkhouri mentioned this pull request Aug 20, 2025

adds traits to dependency output in show-dependencies --json and --text #9034

Open

bkhouri enabled auto-merge (squash) August 20, 2025 16:55

bkhouri merged commit f042205 into swiftlang:main Aug 21, 2025
6 checks passed

bkhouri deleted the t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST branch August 21, 2025 17:02

Tests: Migrate PackageCommandTests to Swift Testing and Augment #9012

Tests: Migrate PackageCommandTests to Swift Testing and Augment #9012

Uh oh!

Conversation

bkhouri commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkhouri commented Aug 11, 2025

Uh oh!

cmcgee1024 Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bkhouri Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

bkhouri commented Aug 13, 2025

Uh oh!

bkhouri commented Aug 13, 2025

Uh oh!

bkhouri commented Aug 13, 2025

Uh oh!

bkhouri commented Aug 14, 2025

Uh oh!

bkhouri commented Aug 14, 2025

Uh oh!

bkhouri commented Aug 14, 2025

Uh oh!

bkhouri commented Aug 14, 2025

Uh oh!

bkhouri commented Aug 17, 2025

Uh oh!

bkhouri commented Aug 18, 2025

Uh oh!

bkhouri commented Aug 18, 2025

Uh oh!

bkhouri commented Aug 18, 2025

Uh oh!

bkhouri commented Aug 18, 2025

Uh oh!

bkhouri commented Aug 19, 2025

Uh oh!

bkhouri commented Aug 19, 2025

Uh oh!

bkhouri commented Aug 19, 2025

Uh oh!

bkhouri commented Aug 19, 2025

Uh oh!

cachemeifyoucan commented Aug 19, 2025

Uh oh!

cachemeifyoucan commented Aug 19, 2025

Uh oh!

bkhouri commented Aug 19, 2025

Uh oh!

bkhouri commented Aug 20, 2025

Uh oh!

bkhouri commented Aug 20, 2025

Uh oh!

bkhouri commented Aug 20, 2025

Uh oh!

bkhouri commented Aug 20, 2025

Uh oh!

bkhouri commented Aug 21, 2025

Uh oh!

Uh oh!

Uh oh!

bkhouri commented Aug 11, 2025 •

edited

Loading

cmcgee1024 Aug 12, 2025 •

edited

Loading