adds traits to dependency output in show-dependencies --json and --text #9034
+58
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
bkhouri
requested changes
Aug 16, 2025
|
@bkhouri absolutely - I was keeping it draft until I could see what tests where running and add in something appropriate. Just added now, following the pattern of the other nearby "command tests" |
heckj
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
bripeticca
approved these changes
Aug 19, 2025
|
@swift-ci please test |
jakepetroules
requested changes
Aug 20, 2025
bkhouri
approved these changes
Aug 20, 2025
heckj
force-pushed
the
show-dependencies-traits
branch
from
8c4ef04 to
3d29dbe
Compare
|
@swift-ci please test |
jakepetroules
approved these changes
Aug 26, 2025
|
@swift-ci please test windows platform |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds traits to the output of the show-dependencies command for
--textand--jsonoutput.Motivation:
Exposes the default traits, if any, that are enabled by the dependencies a package.
Resolves: #9033
Modifications:
Extended the logic in show-dependencies to add in the
enabledTraitsfor a resolved package.Result:
The output of show-dependencies includes output akin to
(traits: FirstTrait, SecondTrait)is the resolved package has traits and includes the traits that it has. If the package doesn't offer traits, no additional/new content is displayed in--text.The JSON provided from
show-dependencies --jsonincludes atraitsproperty, empty if there aren't any traits enabled.