-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add documentation comment to getPixelData function #4784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
All Jest tests are passing now ✅. |
|
Hi @omsuneri, |
|
“Hi! Thanks for reviewing. Could you please share the reason it was closed or how I can improve it? I’d love to make the necessary updates.” |
|
Sorry for taking so long to review. |
|
✅ All Jest tests passed! This PR is ready to merge. |
Fix SensorBlocks: getPixelXColor & duplicate fixes
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@walterbender I've split this PR into smaller, focused PRs as you requested. |
|
@walterbender I've split this large PR into three smaller, focused PRs as you requested:
Each PR now contains related changes that are easier to review. Closing this PR in favor of the new ones. Thank you for the feedback! |
Added documentation comment explaining the current color detection functionality in SesnsorsBlocks.js
This comment clarifies that getPixelData() currently only works with turtle-drawn content on overlayCanvas. This is part of my preparation for the GSoC "Color sensor for Music Blocks" project, where I plan to extend color detection to work with uploaded images and webcam feed.