Skip to content

Conversation

@Adityacode-hub
Copy link

Added documentation comment explaining the current color detection functionality in SesnsorsBlocks.js

This comment clarifies that getPixelData() currently only works with turtle-drawn content on overlayCanvas. This is part of my preparation for the GSoC "Color sensor for Music Blocks" project, where I plan to extend color detection to work with uploaded images and webcam feed.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

SensorsBlocks.test.js

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

✅ All Jest tests passed! This PR is ready to merge.

@Adityacode-hub
Copy link
Author

All Jest tests are passing now ✅.
This PR is ready for review and merge.
Thanks!

@Adityacode-hub
Copy link
Author

Hi @omsuneri,
I have created this PR as per the contributing guidelines. All Jest tests have passed successfully.
Kindly review when you get a chance. Thank you!

@Adityacode-hub
Copy link
Author

“Hi! Thanks for reviewing. Could you please share the reason it was closed or how I can improve it? I’d love to make the necessary updates.”

@walterbender
Copy link
Member

Sorry for taking so long to review.
There seem to be a few indentation issues.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

Fix SensorBlocks: getPixelXColor & duplicate fixes
@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@Adityacode-hub
Copy link
Author

@walterbender I've split this PR into smaller, focused PRs as you requested.
Creating separate PRs now. Closing this one.

@Adityacode-hub
Copy link
Author

@walterbender I've split this large PR into three smaller, focused PRs as you requested:

Each PR now contains related changes that are easier to review. Closing this PR in favor of the new ones. Thank you for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants