Adding harmonium with fixed sample #4419
Conversation
|
@pikurasa Could u please review the updated PR for adding harmonium as an instrument with fixed sample |
js/utils/synthutils.js
Outdated
| */ | ||
| const stringInstruments = ["piano","sitar", "guitar", "acoustic guitar", "electric guitar"]; | ||
|
|
||
| const stringInstruments = ["piano","harmonium","sitar", "guitar", "acoustic guitar", "electric guitar"]; |
There was a problem hiding this comment.
perhaps we add spaces after all commas for consistency?
There was a problem hiding this comment.
Sure, Will edit and raise a PR.
|
I tested it. It sounds pretty good. Its pitch center may be off a few cents, but it's an acceptable amount. That said, I don't want that to block it being merged since it's very, very close. We should definitely continue exploring debugging options -- perhaps even creating some more tools available to the user from within the Sampler widget. (pinging @haroon10725 on this comment.) @walterbender I think we may merge it. |
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
3 participants
Description
Users can access the instrument as shown in the video below:
Screen.Recording.2025-02-06.at.3.11.54.PM.mov