Skip to content

Commit e21cab0

Browse files
authored
Adding harmonium with fixed sample (#4419)
* Adding harmonium with fixed sample * Fixed Spacing
1 parent 63088d7 commit e21cab0

File tree

4 files changed

+16
-6
lines changed

4 files changed

+16
-6
lines changed

js/js-export/interface.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -518,6 +518,7 @@ class JSInterface {
518518
} else if (props["constraints"]["type"] === "synth") {
519519
const instruments = [
520520
"piano",
521+
"harmonuium",
521522
"violin",
522523
"viola",
523524
"cello",

js/utils/musicutils.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1110,6 +1110,7 @@ const SELECTORSTRINGS = [
11101110
_("double bass"),
11111111
_("guitar"),
11121112
_("sitar"),
1113+
_("harmoiunm"),
11131114
_("acoustic guitar"),
11141115
_("flute"),
11151116
_("clarinet"),

js/utils/synthutils.js

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,8 @@ const VOICENAMES = [
8282
[_("double bass"), "double bass", "images/voices.svg", "string"],
8383
//.TRANS: sitar musical instrument
8484
[_("sitar"), "sitar", "images/synth.svg", "string"],
85+
//.TRANS: harmonium musical instrument
86+
[_("harmonium"), "harmonium", "images/voices.svg", "string"],
8587
//.TRANS: musical instrument
8688
[_("guitar"), "guitar", "images/voices.svg", "string"],
8789
//.TRANS: musical instrument
@@ -267,7 +269,8 @@ const SOUNDSAMPLESDEFINES = [
267269
"samples/oboe",
268270
"samples/trombone",
269271
"samples/doublebass",
270-
"samples/sitar"
272+
"samples/sitar",
273+
"samples/harmonium"
271274
];
272275

273276
// Some samples have a default volume other than 50 (See #1697)
@@ -304,7 +307,8 @@ const DEFAULTSYNTHVOLUME = {
304307
"vibraphone": 100,
305308
"xylophone": 100,
306309
"japanese drum": 90,
307-
"sitar": 100
310+
"sitar": 100,
311+
"harmonium": 100
308312
};
309313

310314
/**
@@ -337,7 +341,8 @@ const SAMPLECENTERNO = {
337341
"xylophone": ["C4", 39], // pitchToNumber('C', 4, 'C Major')],
338342
"viola": ["D4", 53], // pitchToNumber('D', 4, 'D Major')],
339343
"double bass": ["C4", 39], // pitchToNumber('C', 4, 'C Major')],
340-
"sitar": ["C4", 39] // pitchToNumber('C', 4, 'C Major')]
344+
"sitar": ["C4", 39], // pitchToNumber('C', 4, 'C Major')]
345+
"harmonium": ["C4", 39] // pitchToNumber('C', 4, 'C Major')]
341346
};
342347

343348

@@ -360,8 +365,7 @@ const percussionInstruments = ["koto", "banjo", "dulcimer", "xylophone", "celest
360365
* @constant
361366
* @type {Array<string>}
362367
*/
363-
const stringInstruments = ["piano","sitar", "guitar", "acoustic guitar", "electric guitar"];
364-
368+
const stringInstruments = ["piano", "harmonium", "sitar", "guitar", "acoustic guitar", "electric guitar"];
365369
/**
366370
* Validates and sets parameters for an instrument.
367371
* @function
@@ -834,7 +838,8 @@ function Synth() {
834838
{ name: "celeste", data: CELESTE_SAMPLE },
835839
{ name: "vibraphone", data: VIBRAPHONE_SAMPLE },
836840
{ name: "xylophone", data: XYLOPHONE_SAMPLE },
837-
{ name: "sitar", data: SITAR_SAMPLE }
841+
{ name: "sitar", data: SITAR_SAMPLE },
842+
{ name: "harmonium", data: HARMONIUM_SAMPLE }
838843
],
839844
drum: [
840845
{ name: "bottle", data: BOTTLE_SAMPLE },

sounds/samples/harmonium.js

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)