Skip to content

Search input text hovering issue in advance mode #4164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Search input text hovering issue in advance mode #4164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
939d267
search input text hovering issue in advance mode
subhas-pramanik-09 Dec 21, 2024
b996efa
searchbar hover issue in advance mode
subhas-pramanik-09 Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions css/activities.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,24 @@
margin-top: 60px;
}

#helpfulSearchDiv{
display: block !important;
position: absolute;
background-color: #f0f0f0;
padding: 5px;
border: 1px solid #ccc;
width: 230px;
z-index: 1;
}

#helpfulSearch{
padding: 2px;
border: 2px solid grey;
width: 220px;
height: 20px;
font-size: large;
}

.ui-menu {
position: relative;
background-color: rgba(255, 255, 255, 1);
Expand Down
60 changes: 36 additions & 24 deletions js/activity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,13 +397,6 @@ class Activity {
this.helpfulSearchWidget.style.visibility = "hidden";
this.helpfulSearchWidget.placeholder = _("Search for blocks");
this.helpfulSearchWidget.classList.add("ui-autocomplete");
this.helpfulSearchWidget.style.cssText = `
padding: 2px;
border: 2px solid grey;
width: 220px;
height: 20px;
font-size: large;
`;
this.progressBar = docById("myProgress");
this.progressBar.style.visibility = "hidden";

Expand All @@ -429,18 +422,41 @@ class Activity {
}
this.helpfulSearchDiv = document.createElement("div");
this.helpfulSearchDiv.setAttribute("id", "helpfulSearchDiv");
this.helpfulSearchDiv.style.cssText = `
position: absolute;
background-color: #f0f0f0;
padding: 5px;
border: 1px solid #ccc;
width: 230px;
display: none;
z-index: 1;
`;

document.body.appendChild(this.helpfulSearchDiv);

// Create the div for the close button (cross button)
const closeButtonDiv = document.createElement("div");
closeButtonDiv.style.cssText =
"position: absolute;" +
"top: 10px;" + // Adjust the top position to center it vertically
"right: 10px;" + // Position the button on the right side of the helpfulSearchDiv
"cursor: pointer;";

// Create the cross button itself
const closeButton = document.createElement("button");
closeButton.textContent = "×"; // You can use HTML entity or an icon
closeButton.style.cssText =
"position: absolute;" +
"top: 50%;" + // Center vertically
"right: -30px;" + // Place it outside the input, adjust as needed
"transform: translateY(-50%);" + // Align with vertical center of input
"background: transparent;" +
"border: none;" +
"font-size: large;" +
"cursor: pointer;";

// Append the cross button to the closeButtonDiv
closeButtonDiv.appendChild(closeButton);

// Append the closeButtonDiv to the helpfulSearchDiv
this.helpfulSearchDiv.appendChild(closeButtonDiv);

// Add event listener to remove the search div from the DOM when clicked on the close button
closeButton.addEventListener("click", () => {
this.helpfulSearchDiv.parentNode.removeChild(this.helpfulSearchDiv); // Remove from DOM
});

if (docById("helpfulSearch")) {
docById("helpfulSearch").parentNode.removeChild(
docById("helpfulSearch")
Expand All @@ -453,6 +469,9 @@ class Activity {
* displays helpfulSearchDiv on canvas
*/
this._displayHelpfulSearchDiv = () => {
if (!docById("helpfulSearchDiv")) {
this.setHelpfulSearchDiv(); // Re-create and append the div if it's not found
}
this.helpfulSearchDiv.style.left = docById("helpfulWheelDiv").offsetLeft + 80 * this.getStageScale() + "px";
this.helpfulSearchDiv.style.top = docById("helpfulWheelDiv").offsetTop + 110 * this.getStageScale() + "px";

Expand All @@ -479,13 +498,9 @@ class Activity {
if (docById("helpfulWheelDiv").style.display !== "none") {
docById("helpfulWheelDiv").style.display = "none";
}
if (docById("helpfulSearchDiv").style.display !== "none" && !docById("helpfulSearchDiv").contains(e.target) && e.target.id !== "helpfulSearch") {
docById("helpfulSearchDiv").style.display = "none";
}
that.__tick();
}

document.addEventListener("click", this._hideHelpfulSearchWidget);

/*
* Sets up right click functionality opening the context menus
Expand Down Expand Up @@ -5889,14 +5904,11 @@ class Activity {
that.helpfulSearchWidget.protoblk = ui.item.specialDict;
that.doHelpfulSearch();
},
focus: (event, ui) => {
focus: (event) => {
event.preventDefault();
that.helpfulSearchWidget.value = ui.item.label;
}
});

$j("#helpfulSearch").autocomplete("widget").addClass("scrollSearch");

$j("#helpfulSearch").autocomplete("instance")._renderItem = (ul, item) => {
return $j("<li></li>")
.data("item.autocomplete", item)
Expand Down
Loading