Skip to content

Conversation

@subhas-pramanik-09
Copy link
Contributor

Resolve issue #4163

Now the search bar input text in advance mode not replaced by option search bar.

Screen.Recording.2024-12-21.134019.mp4

@subhas-pramanik-09
Copy link
Contributor Author

@walterbender Sir, Please review the PR

@subhas-pramanik-09 subhas-pramanik-09 changed the title search input text hovering issue in advance mode Search input text hovering issue in advance mode Dec 21, 2024
@subhas-pramanik-09
Copy link
Contributor Author

@walterbender Sir, is this okay or some changes required

@walterbender
Copy link
Member

With your changes (at least with Firefox) the search box is no longer appearing when I click the search button on the pie menu. I understand why you don't update the value in your PR, but not your other changes.

@subhas-pramanik-09
Copy link
Contributor Author

@walterbender Sir I find that the shortcut search bar also don't appear in firefox before this change

@walterbender
Copy link
Member

It shows up from musicblocks.sugarlabs.org. So there is a regression we need to chase down.

@subhas-pramanik-09
Copy link
Contributor Author

It shows up from musicblocks.sugarlabs.org. So there is a regression we need to chase down.

Okay, I am working on it

@subhas-pramanik-09
Copy link
Contributor Author

@walterbender Sir, this change is now shows up in Firefox also. One thing I have changed that the closing of searchbar by click the cross button to recreate the helpfulSearchDiv again

Screen.Recording.2024-12-22.180526.mp4

@subhas-pramanik-09
Copy link
Contributor Author

Please check it Sir

@walterbender walterbender merged commit dee77fc into sugarlabs:master Dec 22, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants