Skip to content

Closing of piemenu for Grid button added outside click option #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2024
Merged

Closing of piemenu for Grid button added outside click option #4086

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7290ce6
Closing of piemenu for Grid button added outside click
subhas-pramanik-09 Nov 29, 2024
2867fa0
added outside click option for closing of piemenu for grid menu
subhas-pramanik-09 Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions js/piemenus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3658,14 +3658,27 @@ const piemenuGrid = (activity) => {
activity.turtles._exitWheel.createWheel(["×", " "]);

activity.turtles._exitWheel.navItems[0].navigateFunction = () => {
docById("wheelDivptm").style.display = "none";
activity.turtles.gridWheel.removeWheel();
activity.turtles._exitWheel.removeWheel();
hidePiemenu(activity);
};

if (docById("helpfulWheelDiv").style.display !== "none") {
docById("helpfulWheelDiv").style.display = "none";
}

const hidePiemenu = (activity) => {
docById("wheelDivptm").style.display = "none";
activity.turtles.gridWheel.removeWheel();
activity.turtles._exitWheel.removeWheel();
};
const clickOutsideHandler = (event) => {
Copy link
Member

@walterbender walterbender Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new line between these definitions (hidePiemenu and clickOutsideHandler) and please remove the extra space of indentation.

Copy link
Contributor Author

@subhas-pramanik-09 subhas-pramanik-09 Nov 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir I did the change ..Is it okay or something else to do

const piemenu = docById("wheelDivptm");
if (!piemenu.contains(event.target)) {
hidePiemenu(activity);
document.removeEventListener("mousedown", clickOutsideHandler);
}
};

document.addEventListener("mousedown", clickOutsideHandler);
};

const piemenuKey = (activity) => {
Expand Down Expand Up @@ -4000,4 +4013,4 @@ const piemenuKey = (activity) => {
if (j !== -1) {
modenameWheel.navigateWheel(j);
}
};
};