Closing of piemenu for Grid button added outside click option #4086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@walterbender Please review sir |
js/piemenus.js
Outdated
| activity.turtles.gridWheel.removeWheel(); | ||
| activity.turtles._exitWheel.removeWheel(); | ||
| }; | ||
| const clickOutsideHandler = (event) => { |
Member
There was a problem hiding this comment.
Please add a new line between these definitions (hidePiemenu and clickOutsideHandler) and please remove the extra space of indentation.
Contributor
Author
There was a problem hiding this comment.
Sir I did the change ..Is it okay or something else to do
Contributor
Author
|
@walterbender Sir, I did that , please check it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the issue #4085 i changes it like that
Current Behaviour
As like other options - New project, clean button user can click the cancel button as well as outside of the piemenu.
User selects the grid from piemenu. After that they can click either the cross "x" button Or outside of the piemenu to close the piemenu. It enhance the experiences of using Grid menu.
Screen Record
issue.resolve.1.mp4