Use file transfer constants

[quozl]

Hard coded integer constants were used instead of enums imported from
TelepathyGLib.

Reported-by: Saumya Mishra [email protected]

[Saumya-Mishra9129]

Reviewed, Looks good to me

[Saumya-Mishra9129]

Gentle reminder, @quozl you can merge it .

[quozl]

It didn't work. Turned out to be something else. Related sugarlabs/Pippy#82. Needs wider testing.

[Saumya-Mishra9129]

It didn't work. Turned out to be something else. Related sugarlabs/Pippy#82. Needs wider testing.

Yeah I agree here. 33ebbd6 , it seems correct to me. But its not working so Possibly there is another regression in Pippy. I still need to test it.
Because @srevinsaju tested it with physics earlier in sugarlabs/physics#44 , but we haven't tested with all other activities.
Edit - I just got the real cause , I compared collabwrapper of Pippy with actual one , find out sugarlabs/Pippy@b655240 is extra and causing the issue here in Pippy. We need to fix this one.
@chimosky what do you say?

[quozl]

We also have to make sure to fix problems in the layer they occur in, rather than exactly where the traceback points.

API documentation for CollabWrapper, with types for objects, may help us to concentrate the change on the correct layer. Several porting problems may have been fixed by either editing activity or CollabWrapper sources.

[Saumya-Mishra9129]

Several porting problems may have been fixed by either editing activity or CollabWrapper sources.

But the main point is that, we maintain collabwrapper as upstream source. So we should not allow changes there at the time of porting in the activity. The collabwarapper files in main upstream and pippy differs which can cause problems while testing (if someone new goes to pippy and test collabwrapper changes there) .

Correct me If I am wrong.

[quozl]

I'm not going to disallow changes to CollabWrapper in activity source. Sometimes a change there may be the only way to solve an immediate problem in the time available. The change ought to be considered for upstreaming to CollabWrapper, and when that happens the change must undergo review, should not change the API without justification, and the CollabWrapper test activity should be able to test the change and the test must pass.

[Saumya-Mishra9129]

I'm not going to disallow changes to CollabWrapper in activity source. Sometimes a change there may be the only way to solve an immediate problem in the time available. The change ought to be considered for upstreaming to CollabWrapper, and when that happens the change must undergo review, should not change the API without justification, and the CollabWrapper test activity should be able to test the change and the test must pass.

Fine thanks. I think a better way would be to test these changes with fructose activities.

[quozl]

That would happen when a fructose activity adopts changes from CollabWrapper. What is important for CollabWrapper is that the test activity demonstrates and tests the API.

[Saumya-Mishra9129]

@quozl why you are reverting the change in 33ebbd6. I tried with test activity - master, it works fine, no such error in log. No need to revert the change here as in 33ebbd6, but yeah it will not work in Pippy because of different issues in Pippy. Getting same error after reverting with test activity,

Traceback (most recent call last):
  File "/usr/share/sugar/activities/collabwrapper/test/collabwrapper.py", line 696, in __notify_state_cb
    input_stream = self._get_input_stream()
  File "/usr/share/sugar/activities/collabwrapper/test/collabwrapper.py", line 744, in _get_input_stream
    return Gio.MemoryInputStream.new_from_data(self._blob, None)
TypeError: Item 0: Must be number, not str

However , while testing with master I found that the data recieved is bytes data i.e. we send data ('One Two Three', 'Test Data') with host and we get b'One Two Three' on guest machine. Shouldn't it be str instead of byte.??

[Saumya-Mishra9129]

I don't think 33ebbd6 is needed.