Update to later CollabWrapper #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick from collabwrapper:7571e3b Signed-off-by: James Cameron <[email protected]>
Activities occasionally need to know their buddy.Owner, so provide it as a property so the activity can avoid importing presence. Cherry-pick from collabwrapper:5b55dad Signed-off-by: James Cameron <[email protected]>
Cherry-pick from collabwrapper:575443c Signed-off-by: James Cameron <[email protected]>
Minor deprecation fix for Decorator @GObject.Property instead of @GObject.property Cherry-pick from collabwrapper:0a56cce plus instantiation fixes Co-authored-by: James Cameron <[email protected]> Signed-off-by: James Cameron <[email protected]>
Hard coded integer constants were used instead of enums imported from TelepathyGLib. Reported-by: Saumya Mishra <[email protected]> Cherry-pick from collabwrapper:881ed15 Signed-off-by: James Cameron <[email protected]>
Member
|
From sugarlabs/collabwrapper#24 (comment) It is proved that sugarlabs/collabwrapper@b740323 will not work with Pippy. The issue which sugarlabs/collabwrapper@b740323 addresses has already fixed in b655240. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on an Ubuntu 19.10 pair of VMs.