Skip to content

Fix a potential bug in the stop method. #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2025
+10 −2
Merged

Fix a potential bug in the stop method. #2133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ece79b2
Fix a potential bug in the stop method.
jaynewstrom-stripe Sep 18, 2025
26e04fd
Uncomment log.
jaynewstrom-stripe Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions android/src/main/java/com/reactnativestripesdk/utils/KeepJsAwakeTask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.reactnativestripesdk.utils

import android.util.Log
import com.facebook.react.bridge.Arguments
import com.facebook.react.bridge.ReactApplicationContext
import com.facebook.react.bridge.UiThreadUtil
Expand Down Expand Up @@ -33,7 +34,14 @@ internal class KeepJsAwakeTask(
fun stop() {
val taskId = taskId ?: return
val headlessJsTaskContext = HeadlessJsTaskContext.getInstance(context)
headlessJsTaskContext.finishTask(taskId)
this.taskId = null

try {
headlessJsTaskContext.finishTask(taskId)
} catch (e: AssertionError) {
// Ignore if task already finished
Log.w("KeepJsAwakeTask", "Tried to stop a non-existent task (id=$taskId)")
} finally {
this.taskId = null
}
}
}
Loading