Fix a potential bug in the stop method. #2133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaynewstrom-stripe
requested review from
charliecruzan-stripe and
a team
as code owners
jaynewstrom-stripe
force-pushed
the
jaynewstrom/fix-stop
branch
from
a6b8494 to
ece79b2
Compare
| headlessJsTaskContext.finishTask(taskId) | ||
| } catch (e: AssertionError) { | ||
| // Ignore if task already finished | ||
| // Log.w("KeepJsAwakeTask", "Tried to stop a non-existent task (id=$taskId)") |
There was a problem hiding this comment.
Shoud we uncomment this?
janicduplessis
approved these changes
Sep 18, 2025
porter-stripe
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A user wrote in suggesting a fix for this, it doesn't seem harmful, so I'm adding it in.
Motivation
https://jira.corp.stripe.com/browse/RUN_MOBILESDK-4693