-
Notifications
You must be signed in to change notification settings - Fork 314
fix(event_loop): raise dedicated exception when encountering max toke… #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c5e4e51
fix(event_loop): raise dedicated exception when encountering max toke…
dbschmigelski 6703819
fix: update integ tests
dbschmigelski c94b74e
fix: rename exception message, add to exception, move earlier in cycle
dbschmigelski 36dd0f9
Update tests_integ/test_max_tokens_reached.py
dbschmigelski e04c73d
Update tests_integ/test_max_tokens_reached.py
dbschmigelski cca2f86
linting
dbschmigelski f647baa
Merge branch 'strands-agents:main' into fix-max-tokens
dbschmigelski 78c5a91
Merge branch 'strands-agents:main' into fix-max-tokens
dbschmigelski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import pytest | ||
|
||
from strands import Agent, tool | ||
from strands.models.bedrock import BedrockModel | ||
from strands.types.exceptions import MaxTokensReachedException | ||
|
||
|
||
@tool | ||
def story_tool(story: str) -> str: | ||
return story | ||
|
||
|
||
def test_context_window_overflow(): | ||
model = BedrockModel(max_tokens=100) | ||
agent = Agent(model=model, tools=[story_tool]) | ||
|
||
with pytest.raises(MaxTokensReachedException): | ||
agent("Tell me a story!") | ||
|
||
assert len(agent.messages) == 1 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.