-
Notifications
You must be signed in to change notification settings - Fork 287
fix(event_loop): raise dedicated exception when encountering max toke… #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbschmigelski
commented
Jul 30, 2025
4 tasks
Unshure
requested changes
Jul 30, 2025
Unshure
requested changes
Jul 31, 2025
Co-authored-by: Nick Clegg <[email protected]>
Co-authored-by: Nick Clegg <[email protected]>
Unshure
approved these changes
Aug 1, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first step to address #541. We indicated our plan
The followup to this will be the HookEvent and HookProvider implementation. The trickiness in this CR is the question of where this, and the followup hook, should go. Some of the interesting points are
My inclination is to execute the hook before MessageAddedEvent and before the trace. Meaning the customer modifies in place then we proceed as normal. This would look like the following but is going to be raised in the followup. Docs will be updated there as well
Related Issues
#541
Documentation PR
strands-agents/docs#195
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.