Skip to content

fix(runtime): do not remove first comment - can break frameworks #6343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

fix(runtime): do not remove first comment - can break frameworks #6343

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e943e3
fix(runtime): do not remove first comment - can break frameworks
Jul 15, 2025
83fb8b0
chore: prettier
Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/runtime/connected-callback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,6 @@ export const connectedCallback = (elm: d.HostElement) => {
cmpMeta.$flags$ & (CMP_FLAGS.hasSlotRelocation | CMP_FLAGS.needsShadowDomShim))
) {
setContentReference(elm);
} else if (BUILD.hydrateClientSide && !(cmpMeta.$flags$ & CMP_FLAGS.hasSlotRelocation)) {
const commendPlaceholder = elm.firstChild as d.RenderNode;
if (
commendPlaceholder?.nodeType === NODE_TYPE.CommentNode &&
!commendPlaceholder['s-cn'] &&
!commendPlaceholder.nodeValue
) {
// if the first child is a comment node that was created by the
// setContentReference() function during SSR, remove it now as
// this component does not need slot relocation and can cause hydration issues
elm.removeChild(commendPlaceholder);
}
}
}

Expand Down
Loading