fix(runtime): do not remove first comment - can break frameworks #6343
+0
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
christian-bromann
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
The Ionic pipeline is passing with this patch 🎉
@johnjenkins thank you so much, you truly have some magic DOM-power!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
A regression was added in #6311.
In an attempt to 'clean up' non-shadow dom trees and minimise 3rd-party-framework hydration mismatch errors, the first empty comment node of a component was removed when the component does not utilise
<slot />s.This node removal had a side-effect as Angular uses empty comments as content placeholders (only in production builds) which caused the Angular app content to not render.
GitHub Issue Number: #6336)
What is the new behavior?
The node removal was reverted. I think with #6314 now in-place all non-shadow components correctly shield their internals from the outside, so this behaviour is no longer required anyway
Documentation
Does this introduce a breaking change?
Testing
Other information