fix(StatusPopupMenu): Refactoring #8341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
caybro
reviewed
Nov 21, 2022
osmaczko
reviewed
Nov 21, 2022
| closePolicy: Popup.CloseOnPressOutside | Popup.CloseOnEscape | ||
| topPadding: 8 | ||
| bottomPadding: 8 | ||
| bottomMargin: 16 | ||
|
|
||
| property int menuItemCount: 0 | ||
| property var subMenuItemIcons: [] | ||
| property StatusAssetSettings assetSettings: StatusAssetSettings { |
There was a problem hiding this comment.
IMO it doesn't belong here. It should be defined by the delegate.
There was a problem hiding this comment.
It's here for nested menus (which is possible with QML):
| color: "transparent" | ||
| } | ||
|
|
||
| property StatusFontSettings fontSettings: StatusFontSettings {} |
igor-sirotin
force-pushed
the
fix/issue-7232
branch
from
dc3ea0e to
426ecf9
Compare
osmaczko
approved these changes
Nov 21, 2022
caybro
approved these changes
Nov 21, 2022
This was referenced Nov 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7232
As continuation of status-im/StatusQ#894.
This is a PR to a temporary branch
fix/status-menuAfter this PR is merged, I will update and test the main application. And create a PR to
master.StatusQ checklist
Screenshot of functionality (including design for comparison)
2022-11-21.11.44.28.mov