Skip to content

StatusMenu refactoring #8505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2022
Merged

StatusMenu refactoring #8505

merged 1 commit into from
Dec 2, 2022

Conversation

igor-sirotin
Copy link
Contributor

@igor-sirotin igor-sirotin commented Nov 29, 2022 •
edited
Loading

Closes #7232

⚠️ The code was already reviewed in:

What does the PR do

  1. Rename menu components as follows:
Old name New name
StatusPopupMenu StatusMenu
StatusMenuItem StatusAction
StatusMenuItemDelegate StatusMenuItem
  1. Fix minor bug of icon color in StatusSearchLocationMenu
  2. Fix minor bug of accessing null properties in StatusMenu in d.assetSettings

Affected areas

All menus across the application

StatusQ checklist

  • add documentation if necessary (new component, new feature)
  • update sandbox app
    • in case of new component, add new component page
    • in case of new features, add variation to existing component page
    • nice to have: add it to the demo application as well
  • test changes in both light and dark theme?

Screenshot of functionality (including design for comparison)

Application login

2022-11-29.21.19.01.mov

Application (dark)

2022-11-29.21.19.39.mov

Application (light)

2022-11-29.21.20.39.mov

@igor-sirotin igor-sirotin requested review from a team, elina2015, endulab and borismelnik and removed request for a team November 29, 2022 18:26
@status-im-auto
Copy link
Member

status-im-auto commented Nov 29, 2022 •
edited
Loading

Jenkins Builds

Click to see older builds (13)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9a3b887 #1 2022-11-29 18:31:23 ~4 min linux-cpp 📄log
✔️ 9a3b887 #1 2022-11-29 18:31:56 ~4 min imports 📄log
✔️ 9a3b887 #1 2022-11-29 18:36:36 ~9 min linux 📦tgz
✔️ 9a3b887 #1 2022-11-29 18:37:46 ~10 min macos 🍎dmg
✔️ 9a3b887 #1 2022-11-29 18:54:07 ~27 min windows 💿exe
✖️ 9a3b887 #1 2022-11-29 19:01:20 ~34 min linux-e2e 📄log
✔️ f9c0bd1 #2 2022-11-30 15:45:07 ~7 min imports 📄log
✔️ f9c0bd1 #2 2022-11-30 15:46:20 ~9 min linux-cpp 📄log
✔️ f9c0bd1 #2 2022-11-30 15:50:55 ~13 min linux 📦tgz
✔️ f9c0bd1 #2 2022-11-30 15:50:59 ~13 min macos 🍎dmg
✔️ f9c0bd1 #2 2022-11-30 16:03:01 ~25 min windows 💿exe
✖️ f9c0bd1 #2 2022-11-30 16:05:31 ~28 min linux-e2e 📄log
✖️ f9c0bd1 #3 2022-12-01 16:08:39 ~21 min linux-e2e 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4771b9a #3 2022-12-01 17:03:32 ~2 min linux-cpp 📄log
✔️ 4771b9a #3 2022-12-01 17:05:41 ~4 min imports 📄log
✔️ 4771b9a #3 2022-12-01 17:09:33 ~8 min macos 🍎dmg
✔️ 4771b9a #3 2022-12-01 17:11:58 ~11 min linux 📦tgz
✔️ 4771b9a #4 2022-12-01 17:24:08 ~23 min linux-e2e 📄log
✔️ 4771b9a #3 2022-12-01 17:25:35 ~24 min windows 💿exe
✔️ 82576d9 #4 2022-12-01 19:06:30 ~4 min imports 📄log
✔️ 82576d9 #4 2022-12-01 19:07:18 ~5 min linux-cpp 📄log
✔️ 82576d9 #4 2022-12-01 19:09:11 ~6 min macos 🍎dmg
✔️ 82576d9 #4 2022-12-01 19:11:00 ~8 min linux 📦tgz
✔️ 82576d9 #4 2022-12-01 19:23:13 ~20 min windows 💿exe
✖️ 82576d9 #5 2022-12-01 19:25:43 ~23 min linux-e2e 📄log
✔️ 82576d9 #6 2022-12-01 20:06:13 ~22 min linux-e2e 📄log

@igor-sirotin igor-sirotin changed the title Fix/status menu StatusMenu refactoring Nov 29, 2022
caybro
caybro reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just some minor remarks inline

Will test tomorrow

ui/imports/shared/controls/chat/ProfileHeader.qml
icon.name: "download"
iconRotation: 180
assetSettings.name: "download"
assetSettings.rotation: 180
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have a "download" icon? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, not in the repository 🙂

@caybro caybro added the testing label Dec 1, 2022
caybro
caybro approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine, not a single issue spotted, well done!

@caybro caybro added tested and removed testing labels Dec 1, 2022
@caybro
Copy link
Member

caybro commented Dec 1, 2022

Pls squash the commits

@igor-sirotin
Copy link
Contributor Author

igor-sirotin commented Dec 1, 2022 •
edited
Loading

Pls squash the commits

@caybro, doesn't GItHub squash them when closing PR?

@caybro
Copy link
Member

caybro commented Dec 1, 2022

Pls squash the commits

@caybro, doesn't GItHub squash them when closing PR?

I don't think so, at least not in our setup

jrainville
jrainville approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Individual PRs have already been reviewewd

@jrainville
Copy link
Member

doesn't GItHub squash them when closing PR?

Nope. You can keep multiple commits if you prefer, but at least squash the ones that don't use the commit guidelines

@igor-sirotin
Copy link
Contributor Author

Commits squashed. No code changes made.

elina2015
elina2015 approved these changes Dec 2, 2022
View reviewed changes
Copy link

@elina2015 elina2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved

@igor-sirotin igor-sirotin merged commit e3bfdc0 into master Dec 2, 2022
@igor-sirotin igor-sirotin deleted the fix/status-menu branch December 2, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caybro caybro caybro approved these changes

@jrainville jrainville jrainville approved these changes

@elina2015 elina2015 elina2015 approved these changes

@endulab endulab Awaiting requested review from endulab endulab was automatically assigned from status-im/desktop-devs

@borismelnik borismelnik Awaiting requested review from borismelnik borismelnik was automatically assigned from status-im/desktop-devs

@osmaczko osmaczko Awaiting requested review from osmaczko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor StatusPopupMenu
5 participants
@igor-sirotin @status-im-auto @caybro @jrainville @elina2015