apollo_node: move eth/strk config from consensus_manager to l1_gas_price_provider_config

[guy-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[guy-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_node: move eth/strk config from consensus_manager to l1_gas_price_provider_config #8062 👈 (View in Graphite)
• apollo_l1_gas_price: put eth/strk oracle into gas price provider #8061
• apollo_l1_gas_price: change error value from &str to String #8060
• apollo_l1_gas_price: make eth/strk oracle errors cloneable #8059
• apollo_l1_gas_price: allow eth_to_strk_oracle to clone and debug #8058
• main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-07-20T13:39:04Z
• Started at 2025-07-20T13:39:20Z
• Started at 2025-07-20T13:40:42Z
• Started at 2025-07-28T14:48:11Z
• Started at 2025-07-28T14:48:11Z
• Started at 2025-07-29T14:19:12Z
• Started at 2025-07-30T14:07:08Z
• Started at 2025-07-30T14:07:21Z
• Started at 2025-07-31T07:36:24Z
• Started at 2025-08-03T08:30:13Z
• Started at 2025-08-03T08:52:52Z
• Started at 2025-08-03T09:29:48Z
• Started at 2025-08-03T12:34:04Z
• Started at 2025-08-03T13:15:02Z
• Started at 2025-08-04T12:08:02Z
• Started at 2025-08-04T12:36:57Z
• Started at 2025-08-04T12:38:25Z
• Started at 2025-08-04T12:55:56Z
• Started at 2025-08-04T12:56:14Z
• Started at 2025-08-04T15:58:03Z
• Started at 2025-08-05T10:14:53Z

[github-actions]

Benchmark movements: tree_computation_flow performance improved 😺 tree_computation_flow time: [34.732 ms 34.760 ms 34.791 ms] change: [-4.1332% -2.4877% -1.0279%] (p = 0.00 < 0.05) Performance has improved. Found 4 outliers among 100 measurements (4.00%) 2 (2.00%) high mild 2 (2.00%) high severe

[asmaastarkware]

Reviewed 8 of 9 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

[matan-starkware]

Reviewed 8 of 9 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)

---

crates/apollo_l1_gas_price/src/eth_to_strk_oracle.rs line 51 at r2 (raw file):

}

#[derive(Clone, Debug, Deserialize, Serialize, PartialEq, Validate)]

What does this do?

Code quote:

#[derive(Clone, Debug, Deserialize, Serialize, PartialEq, Validate)]

[guy-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matan-starkware)

---

crates/apollo_l1_gas_price/src/eth_to_strk_oracle.rs line 51 at r2 (raw file):

Previously, matan-starkware wrote…

What does this do?

All the configs under NodeConfig have #[validate] on them... even this one that doesn't have any actual validation.

I think that for uniformity this is a good thing, and if we add validation on the individual fields we won't have to change anything else.

[Itay-Tsabary-Starkware]

Reviewable status: 2 of 31 files reviewed, 2 unresolved discussions (waiting on @asmaastarkware, @guy-starkware, and @matan-starkware)

---

crates/apollo_l1_gas_price/src/eth_to_strk_oracle.rs line 51 at r2 (raw file):

Previously, guy-starkware wrote…

All the configs under NodeConfig have #[validate] on them... even this one that doesn't have any actual validation.

I think that for uniformity this is a good thing, and if we add validation on the individual fields we won't have to change anything else.

Please keep Validate, this enables recursively validating the subconfigs 🙏 (or manually implement)

---

crates/apollo_deployments/resources/app_configs/consensus_manager_config.json line 28 at r3 (raw file):

  "consensus_manager_config.eth_to_strk_oracle_config.lag_interval_seconds": 900,
  "consensus_manager_config.eth_to_strk_oracle_config.max_cache_size": 100,
  "consensus_manager_config.eth_to_strk_oracle_config.query_timeout_sec": 3,

I'd expect the addition of the prefix-truncated values in one of the (other) config files in this directory. Is that related to the error you're experiencing?

Code quote:

  "consensus_manager_config.eth_to_strk_oracle_config.lag_interval_seconds": 900,
  "consensus_manager_config.eth_to_strk_oracle_config.max_cache_size": 100,
  "consensus_manager_config.eth_to_strk_oracle_config.query_timeout_sec": 3,

[guy-starkware]

Reviewable status: 1 of 33 files reviewed, 2 unresolved discussions (waiting on @asmaastarkware, @Itay-Tsabary-Starkware, and @matan-starkware)

---

crates/apollo_deployments/resources/app_configs/consensus_manager_config.json line 28 at r3 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

I'd expect the addition of the prefix-truncated values in one of the (other) config files in this directory. Is that related to the error you're experiencing?

I've moved this into the l1_gas_price_provider_config and have no more problems.

---

crates/apollo_l1_gas_price/src/eth_to_strk_oracle.rs line 51 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please keep Validate, this enables recursively validating the subconfigs 🙏 (or manually implement)

Will do.

[Itay-Tsabary-Starkware]

Reviewed 1 of 3 files at r2, 1 of 29 files at r3.
Reviewable status: 2 of 33 files reviewed, 3 unresolved discussions (waiting on @asmaastarkware, @guy-starkware, and @matan-starkware)

---

crates/apollo_deployments/resources/testing_secrets.json line 3 at r5 (raw file):

{
    "base_layer_config.node_url": "http://anvil-service.anvil.svc.cluster.local:8545",
    "l1_gas_price_provider_config.eth_to_strk_oracle_config.url_header_list": "http://dummy-eth2strk-oracle-service.dummy-eth2strk-oracle.svc.cluster.local/eth_to_strk_oracle?timestamp=:9000",

Please alphabetize the fields in this file 🙏

Code quote:

    "l1_gas_price_provider_config.eth_to_strk_oracle_config.url_header_list": "http://dummy-eth2strk-oracle-service.dummy-eth2strk-oracle.svc.cluster.local/eth_to_strk_oracle?timestamp=:9000",

[Itay-Tsabary-Starkware]

Reviewable status: 2 of 33 files reviewed, 6 unresolved discussions (waiting on @asmaastarkware, @guy-starkware, and @matan-starkware)

---

crates/apollo_deployments/resources/app_configs/consensus_manager_config.json line 28 at r3 (raw file):

Previously, guy-starkware wrote…

I've moved this into the l1_gas_price_provider_config and have no more problems.

GG EZ

---

crates/apollo_deployments/src/test_utils.rs line 21 at r5 (raw file):

    )]
    l1_gas_price_provider_config_config_eth_to_strk_oracle_config_url_header_list:
        Option<Vec<UrlAndHeaders>>,

ditto ^

Code quote:

    #[serde(
        rename = "l1_gas_price_provider_config.eth_to_strk_oracle_config.url_header_list",
        serialize_with = "serialize_optional_list_with_url_and_headers_wrapper"
    )]
    l1_gas_price_provider_config_config_eth_to_strk_oracle_config_url_header_list:
        Option<Vec<UrlAndHeaders>>,

---

crates/apollo_deployments/src/test_utils.rs line 58 at r5 (raw file):

                    headers: Default::default(),
                }],
            ),

ditto ^

Code quote:

            l1_gas_price_provider_config_config_eth_to_strk_oracle_config_url_header_list: Some(
                vec![UrlAndHeaders {
                    url: Url::parse("https://arbitrary.eth_to_strk_oracle.url").unwrap(),
                    headers: Default::default(),
                }],
            ),

---

crates/apollo_deployments/resources/app_configs/l1_gas_price_provider_config.json line 8 at r5 (raw file):

  "l1_gas_price_provider_config.eth_to_strk_oracle_config.lag_interval_seconds": 900,
  "l1_gas_price_provider_config.eth_to_strk_oracle_config.max_cache_size": 100,
  "l1_gas_price_provider_config.eth_to_strk_oracle_config.query_timeout_sec": 3

ditto ^

Code quote:

  "l1_gas_price_provider_config.eth_to_strk_oracle_config.lag_interval_seconds": 900,
  "l1_gas_price_provider_config.eth_to_strk_oracle_config.max_cache_size": 100,
  "l1_gas_price_provider_config.eth_to_strk_oracle_config.query_timeout_sec": 3

---

crates/apollo_node/src/components.rs line 449 at r5 (raw file):

                l1_gas_price_provider_config.clone(),
                Arc::new(eth_to_strk_oracle_client),
            ))

Please wrap this in a fn that takes l1_gas_price_provider_config as an arg and returns L1GasPriceProvider.
The top level module should not be aware of this internally-used client (I understand why you'd want it for dependency injection, but this should be abstracted away from the top level module).

Code quote:

            Some(L1GasPriceProvider::new(
                l1_gas_price_provider_config.clone(),
                Arc::new(eth_to_strk_oracle_client),
            ))

---

crates/apollo_integration_tests/src/integration_test_manager.rs line 903 at r5 (raw file):

        spawn_local_success_recorder(base_layer_ports.get_next_port());
    let (eth_to_strk_oracle_url, _join_handle_eth_to_strk_oracle) =
        spawn_local_eth_to_strk_oracle(base_layer_ports.get_next_port());

Could you please add a todo on my name here (tsabary) to move these to the start of the test, and to properly propagate their values when relevant?

Code quote:

    // All nodes use the same recorder_url and eth_to_strk_oracle_url.
    let (recorder_url, _join_handle) =
        spawn_local_success_recorder(base_layer_ports.get_next_port());
    let (eth_to_strk_oracle_url, _join_handle_eth_to_strk_oracle) =
        spawn_local_eth_to_strk_oracle(base_layer_ports.get_next_port());

[guy-starkware]

Reviewable status: 2 of 33 files reviewed, 6 unresolved discussions (waiting on @asmaastarkware, @Itay-Tsabary-Starkware, and @matan-starkware)

---

crates/apollo_deployments/resources/testing_secrets.json line 3 at r5 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please alphabetize the fields in this file 🙏

Ok.

---

crates/apollo_deployments/resources/app_configs/l1_gas_price_provider_config.json line 8 at r5 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

ditto ^

Done.

---

crates/apollo_deployments/src/test_utils.rs line 58 at r5 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

ditto ^

Done.

---

crates/apollo_integration_tests/src/integration_test_manager.rs line 903 at r5 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Could you please add a todo on my name here (tsabary) to move these to the start of the test, and to properly propagate their values when relevant?

sure.

---

crates/apollo_node/src/components.rs line 449 at r5 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please wrap this in a fn that takes l1_gas_price_provider_config as an arg and returns L1GasPriceProvider.
The top level module should not be aware of this internally-used client (I understand why you'd want it for dependency injection, but this should be abstracted away from the top level module).

Good idea.

[Itay-Tsabary-Starkware]

Reviewed 4 of 29 files at r3, 5 of 10 files at r5, 6 of 6 files at r6, all commit messages.
Reviewable status: 17 of 33 files reviewed, 1 unresolved discussion (waiting on @asmaastarkware, @guy-starkware, and @matan-starkware)

[guy-starkware]

Reviewed 1 of 3 files at r2, 6 of 29 files at r3, 16 of 17 files at r4, 10 of 10 files at r5.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)