apollo_l1_gas_price: put eth/strk oracle into gas price provider #8061
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
This change is |
guy-starkware
changed the base branch from
guyn/l1price/error_with_string
to
graphite-base/8061
guy-starkware
force-pushed
the
guyn/l1price/rate_from_provider
branch
from
6de36bf to
c8cac00
Compare
guy-starkware
force-pushed
the
graphite-base/8061
branch
from
df2e22a to
c2cab4c
Compare
guy-starkware
changed the base branch from
graphite-base/8061
to
guyn/l1price/error_with_string
guy-starkware
force-pushed
the
guyn/l1price/rate_from_provider
branch
2 times, most recently
from
c6217b6 to
07e6f76
Compare
guy-starkware
force-pushed
the
guyn/l1price/error_with_string
branch
from
c2cab4c to
118f4be
Compare
There was a problem hiding this comment.
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)
crates/apollo_consensus_orchestrator/src/sequencer_consensus_context_test.rs line 718 at r1 (raw file):
// }); // deps.eth_to_strk_oracle_client = eth_to_strk_oracle_client; }
Suggestion:
deps.l1_gas_price_provider = l1_prices_oracle_client;
}
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware)
crates/apollo_consensus_orchestrator/src/sequencer_consensus_context_test.rs line 718 at r1 (raw file):
// }); // deps.eth_to_strk_oracle_client = eth_to_strk_oracle_client; }
Removed... Thanks!
guy-starkware
force-pushed
the
guyn/l1price/rate_from_provider
branch
from
07e6f76 to
56efeb0
Compare
guy-starkware
changed the base branch from
guyn/l1price/error_with_string
to
graphite-base/8061
No description provided.