Skip to content

refactor: remove kwargs from conf generation files #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: refactor/base-changes-for-generators
Choose a base branch
from

Conversation

hetangmodi-crest
Copy link
Contributor

Issue number: ADDON-81314

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

This PR removes the use of kwargs from .conf generation files in the generator module.

PS: This PR is a child PR of #1785

User experience

No change in User experience.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

@hetangmodi-crest hetangmodi-crest self-assigned this Jun 9, 2025
@hetangmodi-crest hetangmodi-crest requested a review from a team as a code owner June 9, 2025 10:53
@hetangmodi-crest hetangmodi-crest added the refactor Issue to track refactor work label Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issue to track refactor work size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant