refactor: base PR for removal of kwargs from generators module #1785
Conversation
| if item.file_name == "app.conf": | ||
| # pass kwargs only for AppConf generator | ||
| file_details = item.file_class( | ||
| global_config, input_dir, output_dir, **kwargs |
There was a problem hiding this comment.
I think **kwargs can be deleted as the init does not expects it.
There was a problem hiding this comment.
Made the changes.
| **kwargs: Any | ||
| ): | ||
| self.description = kwargs["app_manifest"].get_description() | ||
| self.title = kwargs["app_manifest"].get_title() | ||
| self.author = kwargs["app_manifest"].get_authors()[0]["name"] |
There was a problem hiding this comment.
Can we also remove kwargs here and provide app_manifest directly? From what I see, the only initialization is in the commands/build
There was a problem hiding this comment.
Made the changes, moved _get_app_manifest function in utils.py
| self.title = kwargs["app_manifest"].get_title() | ||
| self.author = kwargs["app_manifest"].get_authors()[0]["name"] | ||
| self.addon_version = self._global_config.version | ||
| self.is_visible = str(self._global_config.has_pages()).lower() |
There was a problem hiding this comment.
previously we had global_config.meta.get("isVisible", True), can we replace it with just .has_pages()?
There was a problem hiding this comment.
Updated the code.
| def test_set_attributes_check_for_updates_false( | ||
| mock_app_manifest, |
There was a problem hiding this comment.
nit: I would change it's name to avoid naming conflicts. Same for the rest below
There was a problem hiding this comment.
Renamed the fixture.
Code Coverage 🎉
|
Issue number: ADDON-81314
PR Type
What kind of change does this PR introduce?
Summary
Changes
This PR contains base changes for removal of
kwargsfrom generators module.kwargsfrom conf file generation -> refactor: remove kwargs from conf generation files #1787kwargsfrom XML, HTML and Python file generation -> refactor: remove kwargs from html,python and xml files of generator module #1786PS: It also contains unit test changes for all files of generators module to make the pipeline green.
User experience
No change in User experience.
Checklist
If an item doesn't apply to your changes, leave it unchecked.
Review
Tests
See the testing doc.
Demo/meeting:
Reviewers are encouraged to request meetings or demos if any part of the change is unclear