-ffile-prefix-map=<staging>=. injection in compiler-wrapper#19
Open
SebastianPaucar wants to merge 1 commit into
Open
-ffile-prefix-map=<staging>=. injection in compiler-wrapper#19SebastianPaucar wants to merge 1 commit into
SebastianPaucar wants to merge 1 commit into
Conversation
SebastianPaucar
added a commit
to SebastianPaucar/spack-packages
that referenced
this pull request
Jun 27, 2026
…pack/compiler-wrapper/pull/19) Signed-off-by: SebastianPaucar <paucar.sebastian@hotmail.com>
This was referenced Jun 27, 2026
haampie
reviewed
Jun 29, 2026
| fi | ||
|
|
||
| # -ffile-prefix-map=<staging>=. injection for build reproducibility | ||
| if [ -n "${SPACK_DEBUG_PREFIX_MAP:-}" ]; then |
Member
There was a problem hiding this comment.
This is a compiler flag, it should not be passed to the linker (see mode).
Author
There was a problem hiding this comment.
Just updated. Thanks for pointing it out! Added mode guard on it, so the compiler flag is injected during compilation, not linking.
…tests added in test/run.sh (test_debug_prefix_map) Signed-off-by: SebastianPaucar <paucar.sebastian@hotmail.com>
SebastianPaucar
force-pushed
the
feature/debug-prefix-map
branch
from
7edd455 to
215a209
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
SPACK_DEBUG_PREFIX_MAP, which allows the compiler wrapper to inject-ffile-prefix-map=<staging>=.intocc.shONLY whenSPACK_DEBUG_PREFIX_MAPis set, so that debug information no longer contains the temporary Spack staging directory, replacing it with a relative (.) path instead, avoiding leakage of temporary build paths, and making binaries more reproducible. The new test added intest/run.shverifies that the flag is added only when expected for the C, C++, and Fortran wrappers.Companion PRs for both
spack-packagesand the mainspackrepos will be submitted separately.@haampie, could you please take a look when you have a chance?