(mock compiler_wrapper) sync SPACK_DEBUG_PREFIX_MAP with production recipe#52619
Closed
SebastianPaucar wants to merge 1 commit into
Closed
Conversation
Signed-off-by: SebastianPaucar <paucar.sebastian@hotmail.com>
SebastianPaucar
force-pushed
the
feature/mock-compiler-wrapper-debug-prefix-map
branch
from
3447951 to
8f0dab4
Compare
1 task
Member
|
This PR shouldn't be necessary, the compiler wrapper package here is a leftover from the spack / spack-packages split, I will probably delete it at some point. See also #52407 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR keeps the mock
compiler_wrapperpackage used in unit tests in sync with the production recipe updated in the companion PR spack/spack-packages#5353 inspack-packages. In summary, it setsSPACK_DEBUG_PREFIX_MAPinsetup_dependent_build_environmentto match the behavior added in the following companion PRs:compiler-wrapper) -ffile-prefix-map=<staging>=. injection in compiler-wrapper compiler-wrapper#19spack-packages) setSPACK_DEBUG_PREFIX_MAPfor-ffile-prefix-map=<stage>=.injection at compiler-wrapper level (companion to spack/compiler-wrapper#19) spack-packages#5353That said, and based on the issue:
.spack/vs relative paths vs compiler-wrapper remaps (CERN-HSF GSoC Debuggable Installations) #52580This full
compiler-wrapper-spack-packages-spackworkflow matches the-ffile-prefix-map=<staging>=.injection at compiler-wrapper level suggested by @haampie, @psakievich and @vbrunini, and it is part of the first step (the DWARF remapping) before moving things forward to the source copying at debug time, in accordance with our GSoC project in progress under @wdconinc guidance.Note:
spack stylewarnings encountered on the script are pre-existing (present before this change) and unrelated to this PR.