chore: fix package exports, hoist types, remove stale lockfiles#3011
Merged
jamiepine merged 1 commit intospacedriveapp:mainfrom Feb 6, 2026
Merged
chore: fix package exports, hoist types, remove stale lockfiles#3011jamiepine merged 1 commit intospacedriveapp:mainfrom
jamiepine merged 1 commit intospacedriveapp:mainfrom
Conversation
Clean up package.json files: hoist @types/react to root devDependencies with overrides, add proper exports and type declarations to @sd/assets, improve @sd/ts-client exports and move react/@tanstack/react-query to peer dependencies. Fix i64/u64 type mismatch in location manager. Delete stale lockfiles from packages/interface, packages/ts-client, and apps/mobile/modules/sd-mobile-core that shouldn't exist in a monorepo managed by the root lockfile. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![tembo[bot]](https://avatars.githubusercontent.com/in/1223475?s=60&v=4){kind=small}
StarbirdTech
added a commit
to StarbirdTech/spacedrive
that referenced
this pull request
Feb 6, 2026
Add a mobile-dev Cargo profile for faster mobile development builds (parallel codegen, no LTO, opt-level 2) — available opt-in via `cargo build --profile mobile-dev`. Production builds use --release. Fix NDK host_tag to always use darwin-x86_64 on macOS since Google ships universal binaries under that path. Make aws-lc-sys cache cleaning opt-in via CLEAN_AWS_LC=1 to enable incremental iOS builds. Scope Metro file watcher to src/ and packages/ instead of the entire monorepo (avoids watching 4.5GB+ Rust target/ dirs) and fix React resolution to use workspace root where bun hoists packages. Apply tembo review feedback from spacedriveapp#3011: fix SVG type declarations to avoid DOM dependency, add sound asset type flexibility, and add public subpath exports to ts-client. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
StarbirdTech
added a commit
to StarbirdTech/spacedrive
that referenced
this pull request
Feb 6, 2026
Add a mobile-dev Cargo profile for faster mobile development builds (parallel codegen, no LTO, opt-level 2) — available opt-in via `cargo build --profile mobile-dev`. Production builds use --release. Fix NDK host_tag to always use darwin-x86_64 on macOS since Google ships universal binaries under that path. Make aws-lc-sys cache cleaning opt-in via CLEAN_AWS_LC=1 to enable incremental iOS builds. Scope Metro file watcher to src/ and packages/ instead of the entire monorepo (avoids watching 4.5GB+ Rust target/ dirs) and fix React resolution to use workspace root where bun hoists packages. Apply tembo review feedback from spacedriveapp#3011: fix SVG type declarations to avoid DOM dependency, add sound asset type flexibility, and add public subpath exports to ts-client. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes package.json exports for monorepo consumers, hoists shared type dependencies to the root, and removes stale lockfiles. Extracted from #2988 to keep the Android PR focused on platform-specific changes.
While getting the mobile app to consume workspace packages I ran into type resolution failures and duplicate dependency issues. These are all general monorepo hygiene fixes that apply regardless of Android support.
Changes
@types/reactand@types/react-domto root devDependencies + overrides to enforce a single version across the monorepo, removed redundant copy fromapps/mobileexportsmap to@sd/assetsso subpath imports (@sd/assets/icons/*, etc.) resolve correctlytypes.d.tsto@sd/assetswith module declarations for image, SVG, video, sound, and lottie imports (React Native compatible)@sd/ts-clientforuseClient,useNormalizedQuery, andsrc/generated/typesreactand@tanstack/react-queryfrom@sd/ts-clientdirect dependencies to peer dependencies — they were already declared as peers but also duplicated independencies, causing resolution conflictspackages/interface/pnpm-lock.yaml,packages/ts-client/package-lock.json,apps/mobile/modules/sd-mobile-core/package-lock.json— the monorepo uses a single root lockfile (bun.lockb)i64/u64type annotation mismatch incore/src/location/manager.rsthat brokecargo checkVerification
cargo check— passescargo build— full build completes cleanbun install— 1755 packages installed, no errorsbun run --filter @sd/tauri typecheckandbun run --filter @sd/web buildboth fail identically onmain(pre-existing Radix UI type compat and missing@sd/interface/platformexport) — no regressions introduced by this PR