Skip to content

[vslib] MACsec interface creation command fails on VM/VS with send_sci=false and SCI combination. #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[vslib] MACsec interface creation command fails on VM/VS with send_sci=false and SCI combination. #1668

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a1083d3
[vslib] Fix MACsec interface creation failiure when send_sci is false.
vikram-nexthop Oct 17, 2025
3cd4e15
Revert "[vslib] Fix MACsec interface creation failiure when send_sci …
vikram-nexthop Oct 17, 2025
bc4c073
[vslib] Fix MACsec interface creation failiure when send_sci is false.
vikram-nexthop Oct 17, 2025
2338b08
Merge branch 'master' into vikram-nexthop-vslib-macsec-send-sci
vikram-nexthop Oct 31, 2025
8ea4c75
Merge branch 'master' into vikram-nexthop-vslib-macsec-send-sci
vikram-nexthop Nov 4, 2025
500f33b
Merge branch 'master' into vikram-nexthop-vslib-macsec-send-sci
vikram-nexthop Nov 11, 2025
a33fc18
Merge branch 'master' into vikram-nexthop-vslib-macsec-send-sci
vikram-nexthop Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions vslib/MACsecManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,9 +395,22 @@ bool MACsecManager::create_macsec_egress_sc(
<< " type macsec "
<< " sci " << attr.m_sci
<< " encrypt " << (attr.m_encryptionEnable ? " on " : " off ")
<< " cipher " << attr.m_cipher
<< " send_sci " << (attr.m_sendSci ? " on " : " off ")
<< " && ip link set dev "
<< " cipher " << attr.m_cipher;

// send_sci=on is the default behavior, so we only need to set it when m_sendSci is false
if (!attr.m_sendSci)
{
ostream
<< " && /sbin/ip link set link "
<< shellquote(attr.m_vethName)
<< " name "
<< shellquote(attr.m_macsecName)
<< " type macsec "
<< " send_sci off";
}

ostream
<< " && /sbin/ip link set dev "
<< shellquote(attr.m_macsecName)
<< " up";

Expand Down
Loading