-
Notifications
You must be signed in to change notification settings - Fork 331
[vslib] MACsec interface creation command fails on VM/VS with send_sci=false and SCI combination. #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vikram-nexthop
wants to merge
7
commits into
sonic-net:master
Choose a base branch
from
nexthop-ai:vikram-nexthop-vslib-macsec-send-sci
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[vslib] MACsec interface creation command fails on VM/VS with send_sci=false and SCI combination. #1668
vikram-nexthop
wants to merge
7
commits into
sonic-net:master
from
nexthop-ai:vikram-nexthop-vslib-macsec-send-sci
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix for #1667
How I did it
Modified MACsec interface creation logic to use a two-step approach:
How to verify it
admin@VM01T3:~$ ip macsec show 83: macsec_eth1: protect on validate strict sc off sa off encrypt on send_sci off end_station off scb off replay off cipher suite: GCM-AES-256, using ICV length 16 TXSC: 226b54b065000001 on SA 0 0: PN 1534, state on, key 8912df4fd8ea3f1547e02a4410f89996 RXSC: 5c0758de98020001, state on 0: PN 1597, state on, key 8912df4fd8ea3f1547e02a4410f89996 offload: off