Add logging #33
Open
Add logging #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Nov 28, 2025
Merged
piotmag769
reviewed
Nov 28, 2025
| // Filter out less important logs because they're too verbose, | ||
| // and with them the profile file quickly grows to several GBs of data. | ||
| let profile_layer = profile_layer.with_filter( | ||
| Targets::new().with_default(LevelFilter::TRACE).with_target("salsa", LevelFilter::WARN), |
Collaborator
There was a problem hiding this comment.
We don't use salsa. We should put filter here so that we don't collect logs from foundry (and scarb in the future).
piotmag769
reviewed
Nov 28, 2025
| Ok(()) | ||
| } | ||
|
|
||
| pub fn init_logging() -> Option<impl Drop> { |
Collaborator
There was a problem hiding this comment.
This should be crate specific, not struct specific. Put it as a standalone function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.