Make handle_request method of debugger
#29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Nov 28, 2025
Merged
piotmag769
reviewed
Nov 28, 2025
Collaborator
piotmag769
left a comment
piotmag769
left a comment
There was a problem hiding this comment.
Would be good here to introduce the trait I mentioned before - if it's too much rebasing can be in another PR
| ServerResponse::Error("Set function breakpoints is not yet supported".into()) | ||
| } | ||
| impl CairoDebugger { | ||
| pub(crate) fn handle_request(&self, request: Request) -> Result<HandleResult> { |
Collaborator
There was a problem hiding this comment.
Suggested change
| pub(crate) fn handle_request(&self, request: Request) -> Result<HandleResult> { | |
| pub fn handle_request(&self, request: Request) -> Result<HandleResult> { |
This module is not visible from lib.rs anyways
Comment on lines
+13
to
+15
| pub enum HandleResult { | ||
| Handled, | ||
| } |
Collaborator
There was a problem hiding this comment.
I am wondering if we could somehow return sth from handle_request that is an info for the server about what it should do next (send request/event/halt and wait for continue etc.), like it was before. This way we give the control back to the server event loop, which results in clearer code. And we don't need server state in this function anymore
Open
ddoktorski
force-pushed
the
move-debugger-from-lib
branch
from
a5ef870 to
fa0a56f
Compare
ddoktorski
force-pushed
the
handle-requests
branch
from
aa4b2b6 to
0a954c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.