Skip to content

chore: bump actions to resolve Node.js 20 deprecation warnings - #59

Merged
jnsgruk merged 7 commits into
mainfrom
copilot/bump-nodejs-versions
Mar 25, 2026
Merged

chore: bump actions to resolve Node.js 20 deprecation warnings#59
jnsgruk merged 7 commits into
mainfrom
copilot/bump-nodejs-versions

Conversation

Copilot AI commented Mar 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Replace the third-party JasonEtco/create-an-issue@v2 action (pinned to Node.js 20, with no node24 release planned) with an inline bash step using tools already available on GitHub runners.

Changes

  • call-for-testing/action.yaml — Replace JasonEtco/create-an-issue@v2 with inline bash using yq, sed/envsubst, and gh issue create
  • call-for-testing/test-template-render.sh — Remove development-only test script
  • Fix lint failure — Add SC2001 to shellcheck exclusions (sed with capture groups can't use ${var//pattern/replace})
  • Verify lint passes locally

Compatibility

The action output (${{ steps.issue.outputs.number }}) is unchanged — no downstream consumer updates needed.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits March 22, 2026 22:12
Copilot AI changed the title [WIP] Bump Node.js versions to address warnings chore: bump actions to resolve Node.js 20 deprecation warnings Mar 22, 2026
Copilot AI requested a review from jnsgruk March 22, 2026 22:17
Replace the third-party JasonEtco/create-an-issue@v2 action (pinned to
Node.js 20) with an inline bash step that uses yq for front-matter
parsing, sed/envsubst for template rendering, and gh issue create for
issue creation. All tools are pre-installed on GitHub runners.

Also add test-template-render.sh for local verification of template
rendering with representative environment variables.

Co-authored-by: jnsgruk <668505+jnsgruk@users.noreply.github.com>
Agent-Logs-Url: https://github.com/snapcrafters/ci/sessions/13d59c85-53d0-47e4-896a-de7268bf26fd
@jnsgruk
jnsgruk marked this pull request as ready for review March 23, 2026 06:30

@jnsgruk jnsgruk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the template rendering locally, seems to work just fine and this way we've dropped a dependency on two third-party Github Actions.

@jnsgruk
jnsgruk merged commit d8f2461 into main Mar 25, 2026
1 check passed
@jnsgruk
jnsgruk deleted the copilot/bump-nodejs-versions branch March 25, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants