chore: bump actions to resolve Node.js 20 deprecation warnings (#59)

* Initial plan

* chore: bump actions/upload-artifact from v4 to v6

Co-authored-by: jnsgruk <668505+jnsgruk@users.noreply.github.com>
Agent-Logs-Url: https://github.com/snapcrafters/ci/sessions/2f535909-0ff8-45a7-b0b9-c25d0d9b3cfe

* chore: bump actions/github-script from v7 to v8

Co-authored-by: jnsgruk <668505+jnsgruk@users.noreply.github.com>
Agent-Logs-Url: https://github.com/snapcrafters/ci/sessions/2f535909-0ff8-45a7-b0b9-c25d0d9b3cfe

* feat: replace diddlesnaps/snapcraft-review-action with local review-snap action

Co-authored-by: jnsgruk <668505+jnsgruk@users.noreply.github.com>
Agent-Logs-Url: https://github.com/snapcrafters/ci/sessions/2f535909-0ff8-45a7-b0b9-c25d0d9b3cfe

* feat: replace JasonEtco/create-an-issue with inline bash using gh CLI

Replace the third-party JasonEtco/create-an-issue@v2 action (pinned to
Node.js 20) with an inline bash step that uses yq for front-matter
parsing, sed/envsubst for template rendering, and gh issue create for
issue creation. All tools are pre-installed on GitHub runners.

Also add test-template-render.sh for local verification of template
rendering with representative environment variables.

Co-authored-by: jnsgruk <668505+jnsgruk@users.noreply.github.com>
Agent-Logs-Url: https://github.com/snapcrafters/ci/sessions/13d59c85-53d0-47e4-896a-de7268bf26fd

* chore: remove test-template-render.sh from repo

Co-authored-by: jnsgruk <668505+jnsgruk@users.noreply.github.com>
Agent-Logs-Url: https://github.com/snapcrafters/ci/sessions/22aefc7a-631c-4f0c-933d-591d1e2957cd

* fix: add SC2001 to shellcheck exclusions for sed with capture groups

Co-authored-by: jnsgruk <668505+jnsgruk@users.noreply.github.com>
Agent-Logs-Url: https://github.com/snapcrafters/ci/sessions/0154be37-ee61-4906-ad2b-ddbcb143a463

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jnsgruk <668505+jnsgruk@users.noreply.github.com>

Author: Copilot

.github/shellcheck-actions.sh

@@ -5,6 +5,7 @@ DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )
 
 export SHELLCHECK_OPTS=(
     "-s" "bash"
+    "-e" "2001"
     "-e" "2296"
     "-e" "2157"
     "-e" "2129"

README.md

@@ -12,6 +12,7 @@ The actions in this repo are all used during the build, test and release of our
 - [snapcrafters/ci/parse-snapcraft-yaml](parse-snapcraft-yaml/README.md)
 - [snapcrafters/ci/promote-to-stable](promote-to-stable/README.md)
 - [snapcrafters/ci/release-to-candidate](release-to-candidate/README.md)
+- [snapcrafters/ci/review-snap](review-snap/README.md)
 - [snapcrafters/ci/sync-version](sync-version/README.md)
 - [snapcrafters/ci/test-snap-build](test-snap-build/README.md)
 

call-for-testing/action.yaml

@@ -135,8 +135,8 @@ runs:
         awk -v r="${testing_instructions}" '{gsub(/TESTING_INSTRUCTIONS/,r)}1' template-raw.md > template.md
 
     - name: Create call for testing issue
-      uses: JasonEtco/create-an-issue@v2
       id: issue
+      shell: bash
       env:
         GITHUB_TOKEN: ${{ inputs.github-token }}
         snap_name: ${{ steps.snapcraft-yaml.outputs.snap-name }}
@@ -145,5 +145,27 @@ runs:
         table: ${{ steps.build.outputs.table }}
         version: ${{ steps.snapcraft-yaml.outputs.version }}
         promotion_channel: ${{ inputs.promotion-channel }}
-      with:
-        filename: ./template.md
+      run: |
+        # Extract front-matter fields using yq
+        title=$(yq --front-matter=extract '.title' template.md)
+        labels=$(yq --front-matter=extract '.labels' template.md)
+
+        # Extract the body (everything after the closing --- of front-matter)
+        body=$(sed '1{/^---$/!q;};1,/^---$/d' template.md)
+
+        # Render {{ env.VAR }} placeholders using environment variables
+        render() {
+          sed 's/{{ *env\.\([a-zA-Z_][a-zA-Z0-9_]*\) *}}/${\1}/g' <<< "$1" | envsubst
+        }
+
+        rendered_title=$(render "$title")
+        rendered_body=$(render "$body")
+
+        # Create the issue and extract the issue number from the returned URL
+        url=$(gh issue create \
+          --repo "$GITHUB_REPOSITORY" \
+          --title "$rendered_title" \
+          --label "$labels" \
+          --body "$rendered_body")
+
+        echo "number=$(basename "$url")" >> "$GITHUB_OUTPUT"

get-screenshots/action.yaml

@@ -145,7 +145,7 @@ runs:
         echo "window=https://raw.githubusercontent.com/${{ inputs.screenshots-repo }}/main/${file_prefix}-window.png" >> "$GITHUB_OUTPUT"
 
     - name: Comment on call for testing issue with screenshots
-      uses: actions/github-script@v7
+      uses: actions/github-script@v8
       with:
         script: |
           github.rest.issues.createComment({

promote-to-stable/action.yaml

@@ -43,7 +43,7 @@ runs:
 
     - name: Get valid revisions for promotion
       id: valid-revisions
-      uses: actions/github-script@v7
+      uses: actions/github-script@v8
       with:
         result-encoding: string
         script: |
@@ -124,7 +124,7 @@ runs:
         echo "done=$done" >> "$GITHUB_OUTPUT"
 
     - name: Comment on call for testing issue
-      uses: actions/github-script@v7
+      uses: actions/github-script@v8
       with:
         script: |
           let message = ""
@@ -145,7 +145,7 @@ runs:
 
     - name: Close call for testing issue
       if: ${{ steps.promote.outputs.done }} == "done"
-      uses: actions/github-script@v7
+      uses: actions/github-script@v8
       with:
         script: |
           if ("${{ steps.promote.outputs.done }}" === "done" && "${{ steps.promote.outputs.revisions }}".length > 0) {

release-to-candidate/action.yaml

@@ -140,10 +140,10 @@ runs:
         echo "architecture: ${arch}" >> "manifest-${{ inputs.architecture }}.yaml"
 
     - name: Review the built snap
-      uses: diddlesnaps/snapcraft-review-action@v1
+      uses: snapcrafters/ci/review-snap@main
       with:
         snap: ${{ steps.build.outputs.snap }}
-        isClassic: ${{ steps.snapcraft-yaml.outputs.classic }}
+        is-classic: ${{ steps.snapcraft-yaml.outputs.classic }}
         plugs: ${{ steps.snapcraft-yaml.outputs.plugs-file }}
         slots: ${{ steps.snapcraft-yaml.outputs.slots-file }}
 
@@ -175,7 +175,7 @@ runs:
 
     # Upload the manifest file as an artifact for retrieval during future actions
     - name: Upload revision manifest
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v6
       with:
         name: "manifest-${{ inputs.architecture }}"
         path: "manifest-${{ inputs.architecture }}.yaml"

review-snap/README.md

@@ -0,0 +1,40 @@
+# snapcrafters/ci/review-snap
+
+Reviews a built snap package using the same [review-tools] used by the Snap Store. This is a
+composite action replacement for [diddlesnaps/snapcraft-review-action], which is no longer
+maintained.
+
+If you need to specify plug or slot declarations per the [review-tools] README, you can pass them
+using the `plugs` and `slots` inputs.
+
+## Usage
+
+```yaml
+# ...
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Review the built snap
+        uses: snapcrafters/ci/review-snap@main
+        with:
+          snap: my-snap.snap
+```
+
+## API
+
+### Inputs
+
+| Key          | Description                                                         | Required | Default |
+| ------------ | ------------------------------------------------------------------- | :------: | :------ |
+| `is-classic` | Set this to `true` if you are reviewing a classic snap              |    N     |         |
+| `plugs`      | The file holding plugs declarations as json to override permissions |    N     |         |
+| `slots`      | The file holding slots declarations as json to override permissions |    N     |         |
+| `snap`       | The snap file to review                                             |    Y     |         |
+
+### Outputs
+
+None
+
+[review-tools]: https://snapcraft.io/review-tools
+[diddlesnaps/snapcraft-review-action]: https://github.com/diddlesnaps/snapcraft-review-action

review-snap/action.yaml

@@ -0,0 +1,51 @@
+name: Review Snap
+description: Review a built Snap package using the same tools as the Snap Store
+author: Snapcrafters
+branding:
+  icon: check-circle
+  color: orange
+
+inputs:
+  is-classic:
+    description: "Set this to 'true' if you are reviewing a classic snap"
+    required: false
+  plugs:
+    description: "The file holding plugs declarations as json to override default snap permissions"
+    required: false
+  slots:
+    description: "The file holding slots declarations as json to override default snap permissions"
+    required: false
+  snap:
+    description: "The snap file to review"
+    required: true
+
+runs:
+  using: composite
+  steps:
+    - name: Install review-tools
+      shell: bash
+      run: |
+        if ! snap list review-tools &>/dev/null; then
+          sudo snap install review-tools
+        fi
+
+    - name: Review the snap
+      shell: bash
+      env:
+        snap_file: ${{ inputs.snap }}
+        plugs_file: ${{ inputs.plugs }}
+        slots_file: ${{ inputs.slots }}
+        is_classic: ${{ inputs.is-classic }}
+      run: |
+        args=()
+        if [[ -n "${plugs_file}" ]]; then
+          args+=("--plugs" "${plugs_file}")
+        fi
+        if [[ -n "${slots_file}" ]]; then
+          args+=("--slots" "${slots_file}")
+        fi
+        if [[ "${is_classic}" == "true" ]]; then
+          args+=("--allow-classic")
+        fi
+        args+=("${snap_file}")
+        review-tools.snap-review "${args[@]}"

run-tests/action.yaml

@@ -77,7 +77,7 @@ runs:
 
     - name: Comment on call for testing issue with test result
       if: success() || failure()
-      uses: actions/github-script@v7
+      uses: actions/github-script@v8
       with:
         script: |
           const fs = require('node:fs');

test-snap-build/README.md

@@ -45,5 +45,5 @@ jobs:
 None
 
 [review-tools]: https://snapcraft.io/review-tools
-[snapcraft-review-tools]: https://github.com/diddlesnaps/snapcraft-review-action/tree/master
+[snapcraft-review-tools]: https://github.com/snapcrafters/ci/tree/main/review-snap
 [dangerous]: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/